Page MenuHomePhabricator
Create Task
Maniphest T94745

cutimecond API parameter either does the wrong thing or has a misleading description
Closed, ResolvedPublic
Actions

Description

The parameter is currently described as "Time limit of user data (like "2 weeks")".

If you enter "2 weeks" this will set the timestamp in the SQL query to a time in the future and no results will be returned.
Instead one must enter "2 weeks ago" in order to get any results.

Either the description of the parameter is wrong
OR
The logic is wrong

Details

SubjectRepoBranchLines +/-
API: Clarify cutimecond behaviour in docs/errorsmediawiki/extensions/CheckUsermaster+4 -4
Customize query in gerrit

Event Timeline

Addshore created this task.Apr 1 2015, 8:01 PM
Addshore raised the priority of this task from to Medium.
Addshore updated the task description. (Show Details)
Addshore added a project: CheckUser.
Addshore subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2015, 8:01 PM
Krenair subscribed.Feb 7 2016, 5:27 AM

I'd prefer not to make breaking changes, let's fix the docs?

Restricted Application added a subscriber: JEumerus. · View Herald TranscriptFeb 7 2016, 5:27 AM
Krenair added a comment.Feb 7 2016, 5:30 AM

The default is -2 weeks. Note the negative.

gerritbot subscribed.Feb 7 2016, 5:32 AM

Change 268930 had a related patch set uploaded (by Alex Monk):
API: Clarify cutimecond behaviour in docs/errors

https://gerrit.wikimedia.org/r/268930

gerritbot added a project: Patch-For-Review.Feb 7 2016, 5:32 AM
Krenair claimed this task.Feb 7 2016, 5:32 AM
Krenair moved this task from General / Unsorted to Patches for review on the CheckUser board.
gerritbot added a comment.Feb 17 2016, 11:37 PM

Change 268930 merged by jenkins-bot:
API: Clarify cutimecond behaviour in docs/errors

https://gerrit.wikimedia.org/r/268930

Krenair closed this task as Resolved.Feb 17 2016, 11:41 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).Feb 18 2016, 12:01 AM
MarcoAurelio moved this task from Patches for review to Done on the CheckUser board.May 9 2016, 8:56 AM
MarcoAurelio removed a project: Patch-For-Review.May 9 2016, 9:05 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL