Page MenuHomePhabricator
Create Task
Maniphest T94764

Further tweaks to WikiGrok UI
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

In the first step (CTA) make it match the mock-up below (ignore text error):

screenshot2.png (366×400 px, 27 KB)

The existing footer should still apply to every other step in the workflow (in all versions):

Screen_Shot_2015-04-01_at_2.43.05_PM.png (264×387 px, 25 KB)

Make the spinner appear in the button after the next button is clicked, rather than the spinner being in the tag area.

Make sure the heart image shows up in the thank you message.

After it's implemented, sit down with Moiz and make sure everything looks awesome.

Details

SubjectRepoBranchLines +/-
Fixing styling of intro and thanks panes in WikiGrokmediawiki/extensions/WikiGrokmaster+35 -13
Customize query in gerrit

Related Objects

Event Timeline

kaldari created this task.Apr 1 2015, 9:44 PM
kaldari raised the priority of this task from to Needs Triage.
kaldari updated the task description. (Show Details)
kaldari added a project: Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2.
kaldari moved this task to Needs Analysis on the Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2 board.
kaldari subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2015, 9:44 PM
kaldari updated the task description. (Show Details)Apr 1 2015, 9:44 PM
kaldari set Security to None.
kaldari mentioned this in T94467: Fix the styling of the footer in the first step of WikiGrok.Apr 1 2015, 9:47 PM
kaldari merged a task: T94467: Fix the styling of the footer in the first step of WikiGrok.
kaldari updated the task description. (Show Details)
kaldari moved this task from Needs Analysis to To Do on the Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2 board.
kaldari added subscribers: phuedx, • MSyed, • KLans_WMF.
kaldari renamed this task from (3) Further tweaks to WikiGrok UI to Further tweaks to WikiGrok UI.Apr 1 2015, 9:50 PM
kaldari edited a custom field.
• bmansurov subscribed.EditedApr 2 2015, 12:50 AM

What about cases like this?

Screen_Shot_2015-04-01_at_8.50.32_PM.png (244×600 px, 20 KB)

• KLans_WMF added a comment.Apr 2 2015, 3:57 PM

Let's cc @MSyed for advice ^

• KLans_WMF added a project: Design.Apr 2 2015, 11:34 PM
• KLans_WMF edited projects, added Mobile-Web-Design; removed Design.
kaldari claimed this task.Apr 3 2015, 12:06 AM
kaldari moved this task from To Do to Doing on the Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2 board.
gerritbot subscribed.Apr 3 2015, 11:24 PM

Change 201862 had a related patch set uploaded (by Kaldari):
Fixing styling of intro and thanks panes in WikiGrok

https://gerrit.wikimedia.org/r/201862

gerritbot added a project: Patch-For-Review.Apr 3 2015, 11:24 PM
kaldari moved this task from Doing to Code Review on the Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2 board.Apr 7 2015, 5:15 PM
phuedx moved this task from Code Review to -1 (Needs More Work) on the Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2 board.Apr 7 2015, 6:35 PM

@kaldari: the jshint job says no.

• JKatzWMF moved this task from -1 (Needs More Work) to Code Review on the Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2 board.Apr 8 2015, 5:01 PM
phuedx moved this task from Code Review to -1 (Needs More Work) on the Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2 board.Apr 8 2015, 5:27 PM
kaldari moved this task from -1 (Needs More Work) to Code Review on the Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2 board.Apr 8 2015, 8:25 PM
phuedx moved this task from Code Review to -1 (Needs More Work) on the Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2 board.Apr 9 2015, 3:51 PM
• KLans_WMF moved this task from Needs Triage to Current Sprint on the Mobile-Web-Design board.Apr 9 2015, 7:54 PM
phuedx added a subscriber: Jdlrobson.EditedApr 10 2015, 9:22 AM

This may be blocked on T95490. We'll need to speak with @Jdlrobson, who brought this up during code review, about moving forward with this.

Edit

… and, I guess, the best approach to start adopting OOJS.

• KLans_WMF added a comment.Apr 13 2015, 4:52 PM

@phuedx any movement on this?

• KLans_WMF edited projects, added Mobile-Web-Sprint-45-Snakes-On-A-Plane; removed Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2.Apr 13 2015, 6:37 PM
• KLans_WMF moved this task from Needs Analysis to -1 (Needs More Work) on the Mobile-Web-Sprint-45-Snakes-On-A-Plane board.Apr 13 2015, 6:46 PM
kaldari moved this task from -1 (Needs More Work) to Code Review on the Mobile-Web-Sprint-45-Snakes-On-A-Plane board.Apr 13 2015, 9:07 PM
• bmansurov moved this task from Code Review to Ready for Signoff on the Mobile-Web-Sprint-45-Snakes-On-A-Plane board.Apr 13 2015, 9:21 PM
gerritbot added a comment.Apr 13 2015, 9:21 PM

Change 201862 merged by jenkins-bot:
Fixing styling of intro and thanks panes in WikiGrok

https://gerrit.wikimedia.org/r/201862

Diffusion mentioned this in rMEXT2c6b0fe9ad45: Updated mediawiki/extensions Project: mediawiki/extensions/WikiGrok….Apr 13 2015, 9:22 PM
kaldari mentioned this in rEWGR712173ebabab: Fixing styling of intro and thanks panes in WikiGrok.Apr 13 2015, 9:33 PM
phuedx added a subscriber: • KHammerstein.Apr 14 2015, 9:59 AM

This is now ready for design review and sign off if appropriate. Ping @KHammerstein, @MSyed.

phuedx added a comment.Apr 22 2015, 8:58 AM

Ping @MSyed.

• MSyed added a comment.Apr 22 2015, 6:07 PM

I'm happy with this :)

phuedx closed this task as Resolved.Apr 22 2015, 6:08 PM
phuedx moved this task from Ready for Signoff to Done on the Mobile-Web-Sprint-45-Snakes-On-A-Plane board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL