Page MenuHomePhabricator
Create Task
Maniphest T94818

Flow should fire wikipage.content on content insertion
Closed, ResolvedPublic
Actions

Description

According to the documentation, the hook wikipage.content is meant to be fired when content is added to the DOM. Flow should probably fire it when inserting and previewing post/header content (in order to behave like standard talk pages).

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fire wikipage.content hook after content updatemediawiki/extensions/Flowmaster+20 -2
Customize query in gerrit

Event Timeline

Ltrlg created this task.Apr 2 2015, 9:27 AM
Ltrlg raised the priority of this task from to Needs Triage.
Ltrlg updated the task description. (Show Details)
Ltrlg added a project: StructuredDiscussions.
Ltrlg subscribed.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 2 2015, 9:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
He7d3r added a project: JavaScript.Apr 3 2015, 12:11 AM
He7d3r set Security to None.
• Mattflaschen-WMF added a project: Parsoid.Apr 3 2015, 1:06 AM
• Mattflaschen-WMF subscribed.

A complicating factor is that most listeners will probably expect the PHP-formatted DOM, but this would be the Parsoid format. Not sure if this is a big deal, but maybe we should add a parameter.

• Mattflaschen-WMF added a subscriber: Krinkle.Apr 3 2015, 1:06 AM
Arlolra triaged this task as High priority.Apr 22 2015, 2:23 PM
Arlolra lowered the priority of this task from High to Low.
Arlolra raised the priority of this task from Low to Needs Triage.
Arlolra moved this task from Needs Triage to In Progress on the Parsoid board.
Arlolra moved this task from In Progress to Non-Parsing-Team Tasks on the Parsoid board.
Arlolra subscribed.
• Mattflaschen-WMF triaged this task as Low priority.Apr 22 2015, 5:49 PM
Arlolra unsubscribed.Apr 22 2015, 5:54 PM
gerritbot subscribed.Mar 11 2019, 3:11 PM

Change 495698 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Flow@master] Fire wikipage.content hook after content update

https://gerrit.wikimedia.org/r/495698

Restricted Application added a project: Growth-Team. · View Herald TranscriptMar 11 2019, 3:11 PM
gerritbot added a project: Patch-For-Review.Mar 11 2019, 3:11 PM
JTannerWMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Mar 19 2019, 6:19 PM
JTannerWMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Apr 9 2019, 6:48 PM

Change 495698 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Fire wikipage.content hook after content update

https://gerrit.wikimedia.org/r/495698

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.25; 2019-04-09).Apr 9 2019, 7:01 PM
JTannerWMF moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Apr 10 2019, 4:24 PM
Etonkovidova closed this task as Resolved.Apr 12 2019, 8:21 PM
Etonkovidova claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits