When I do something like
item = ItemPage(self.repo, '-1')
item.editLabels({uselang: title})
item.addClaim(claim, bot=True)(just assume the variables are defined, see https://gerrit.wikimedia.org/r/#/c/166629/14 for context), I get:
site.py", line 5629, in addClaim
if claim.getID() in item.claims:
AttributeError: 'ItemPage' object has no attribute 'claims'
<type 'exceptions.AttributeError'>Shouldn't that if check for existence of "item.claims"?
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Instantiate empty ItemPage with empty attributes | pywikibot/core | master | +165 -21 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Xqt | T98663 Deprecate DataSite.createNewItemFromPage | |||
| Resolved | Xqt | T94848 AttributeError: 'ItemPage' object has no attribute 'claims' |
Hmm I couldn't find such a line in addClaims. And that if has also an else branch, so it would also need an elif.
Sorry, paste error.
In my testing I just made it
# Update the item
try:
if claim.getID() in item.claims:
item.claims[claim.getID()].append(claim)
else:
item.claims[claim.getID()] = [claim]
except AttributeError:
# claims were not defined
passChange 201876 had a related patch set uploaded (by John Vandenberg):
Instantiate empty ItemPage with empty attributes
This is already solved:
>>> import pywikibot
>>> repo = pywikibot.Site().data_repository()
>>> item = pywikibot.ItemPage(repo, '-1')
>>> item.claims
<class 'pywikibot.page._collections.ClaimCollection'>({})Change 201876 abandoned by Xqt:
[pywikibot/core@master] Instantiate empty ItemPage with empty attributes
Reason:
Already solved