Page MenuHomePhabricator
Create Task
Maniphest T94949

Interwiki links to other MediaWiki wikis in the same cluster don't encode section fragment
Closed, DuplicatePublic
Actions

Description

The PHP parser (for enwiki config) parses:

[[mw:Flow#What happens to my custom signature?]]

as:

<a href="//www.mediawiki.org/wiki/Flow#What_happens_to_my_custom_signature.3F" class="extiw" title="mw:Flow">mw:Flow#What happens to my custom signature?</a>

See https://en.wikipedia.org/w/index.php?title=User:Mattflaschen_(WMF)/Sandbox&oldid=654710957

Parsoid (verified using form which also uses enwiki config) parses it as:

<a rel="mw:ExtLink" href="//www.mediawiki.org/wiki/Flow#What happens to my custom signature?" title="mw:Flow" data-parsoid="{&quot;stx&quot;:&quot;simple&quot;,&quot;a&quot;:{&quot;href&quot;:&quot;//www.mediawiki.org/wiki/Flow#What happens to my custom signature?&quot;},&quot;sa&quot;:{&quot;href&quot;:&quot;mw:Flow#What happens to my custom signature?&quot;},&quot;isIW&quot;:true,&quot;dsr&quot;:[0,48,2,2]}">mw:Flow#What happens to my custom signature?</a>

The interwiki table has an iw_local local field which I suspect is involved here (since the section encoding is just the standard encoding you would get if it were not an interwiki link).

The result is that you don't end up at the right section, but rather at the top of the page.

Original report below:

The anchor of this link is not generated correctly:
https://pt.wikipedia.org/w/index.php?title=T%C3%B3pico:Segov5w2cbzfrzck&topic_showPostId=seq389fse5fxehcx#flow-post-seq389fse5fxehcx

It points to
https://www.mediawiki.org/wiki/Flow#What%20happens%20to%20my%20custom%20signature?
but it should point to
https://www.mediawiki.org/wiki/Flow#What_happens_to_my_custom_signature.3F

Details

ProjectBranchLines +/-Subject
mediawiki/services/parsoidmaster+65 -35Munge link fragments and element ids as in the php parser
Customize query in gerrit

Related Objects
Search...

Event Timeline

He7d3r created this task.Apr 3 2015, 12:29 AM
He7d3r raised the priority of this task from to Needs Triage.
He7d3r updated the task description. (Show Details)
He7d3r added a subscriber: He7d3r.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 3 2015, 12:29 AM
He7d3r added projects: StructuredDiscussions, Collaboration-Team-Triage.Apr 3 2015, 12:30 AM
He7d3r set Security to None.
• Mattflaschen-WMF added a subscriber: • Mattflaschen-WMF.Apr 3 2015, 12:32 AM

Please post the full wikitext as well.

He7d3r added a comment.Apr 3 2015, 1:06 AM

The wikitext for the link was [[mw:Flow#What happens to my custom signature?]]. However, Flow mangled the wikitext of the comment with a few tabs (T93851).

• Mattflaschen-WMF renamed this task from Flow breaks links by encoding spaces as %20 instead of _ in their anchors to Interwiki links to other MediaWiki wikis in the same cluster don't encode section fragment.Apr 3 2015, 1:27 AM
• Mattflaschen-WMF updated the task description. (Show Details)
• Mattflaschen-WMF added a project: Parsoid.
• Mattflaschen-WMF updated the task description. (Show Details)
• Mattflaschen-WMF updated the task description. (Show Details)
EBernhardson removed projects: Collaboration-Team-Triage, StructuredDiscussions.Apr 10 2015, 5:53 PM
Nemo_bis merged a task: T88816: Flow does not encode anchors correctly in (interwiki) links.Apr 22 2015, 2:40 PM
Nemo_bis added a subscriber: Nemo_bis.Apr 22 2015, 2:42 PM

This happens also when converting links from LQT, right?

Nemo_bis added a parent task: T92303: Convert LQT pages on MediaWiki.org to Flow (tracking).Apr 22 2015, 2:44 PM
• Mattflaschen-WMF added a comment.Apr 22 2015, 7:15 PM

It's a Parsoid issue, so it will happen anytime Parsoid converts wikitext to HTML (this includes LQT -> Flow conversion).

• DannyH removed a parent task: T92303: Convert LQT pages on MediaWiki.org to Flow (tracking).Apr 23 2015, 12:14 AM
Arlolra claimed this task.Jul 20 2015, 9:20 PM
Arlolra triaged this task as Medium priority.
Arlolra added a subscriber: Arlolra.
gerritbot added a subscriber: gerritbot.Jul 20 2015, 11:12 PM

Change 226032 had a related patch set uploaded (by Arlolra):
Sanitize link fragments

https://gerrit.wikimedia.org/r/226032

gerritbot added a project: Patch-For-Review.Jul 20 2015, 11:12 PM
Arlolra removed Arlolra as the assignee of this task.Oct 16 2015, 3:50 PM
Arlolra removed a project: Patch-For-Review.
gerritbot added a comment.Dec 2 2016, 10:38 PM

Change 324564 had a related patch set uploaded (by Arlolra):
Munge link fragments and element ids as in the php parser

https://gerrit.wikimedia.org/r/324564

gerritbot added a project: Patch-For-Review.Dec 2 2016, 10:38 PM
Nemo_bis added a parent task: T88102: Consider possibility of enabling Flow on translatewiki.net.Dec 3 2016, 10:31 PM
gerritbot added a comment.Dec 6 2016, 7:40 PM

Change 324564 merged by jenkins-bot:
Munge link fragments and element ids as in the php parser

https://gerrit.wikimedia.org/r/324564

Nemo_bis mentioned this in T150112: Internal links pointing to interwikis are not encoded at all.Dec 7 2016, 2:21 PM
Stashbot mentioned this in T110910: Implement <gallery> extension natively inside Parsoid.Dec 7 2016, 9:36 PM
Stashbot mentioned this in T102209: Derive heading ids from heading name, the same way MW core does.
Stashbot added a subscriber: Stashbot.

Mentioned in SAL (#wikimedia-operations) [2016-12-07T21:36:38Z] <arlolra> updated Parsoid to version 3cf19c6b (T110910, T102209, T94949, T150112, T151570, T149209, T150213)

Stashbot mentioned this in T151570: Create Wikivoyage Finnish.Dec 7 2016, 9:36 PM
Stashbot mentioned this in T149209: Parsoid serialised an edit to a wikitext table adding a /n without stripping the double-pipes, breaking the table format (`\n|| align="right" | …`).
Stashbot mentioned this in T150213: Unknown contentmodels.
Arlolra closed this task as Resolved.Dec 7 2016, 10:12 PM
Arlolra claimed this task.

Current output for echo "[[mw:Flow#What happens to my custom signature?]]" | node bin/parse is,

<a rel="mw:ExtLink" href="//www.mediawiki.org/wiki/Flow#What_happens_to_my_custom_signature.3F" title="mw:Flow" data-parsoid='{"stx":"simple","a":{"href":"//www.mediawiki.org/wiki/Flow#What_happens_to_my_custom_signature.3F"},"sa":{"href":"mw:Flow#What happens to my custom signature?"},"isIW":true}'>mw:Flow#What happens to my custom signature?</a>

ie. http://www.mediawiki.org/wiki/Flow#What_happens_to_my_custom_signature.3F

Arlolra closed this task as a duplicate of T150112: Internal links pointing to interwikis are not encoded at all.Dec 7 2016, 10:15 PM
• GWicke added a subscriber: • GWicke.Dec 7 2016, 10:16 PM

See also this follow-up task: T152540: Migrate to HTML5 section ids.

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL