Page MenuHomePhabricator

VE on Flow: Don't change sticky preference if user just switches between VE/wikitext and doesn't make a change
Closed, DuplicatePublic

Description

When a user switches from wikitext to VE and then posts the comment without making any changes, then don't change that user's sticky preference from wikitext to VE.

Ditto the other way, switching from VE to wikitext and not making changes.

We should only change the preference when the user actually makes a change in the entry field.

Event Timeline

DannyH created this task.Apr 3 2015, 1:23 AM
DannyH raised the priority of this task from to Medium.
DannyH updated the task description. (Show Details)
DannyH moved this task to Team discussion on the Collaboration-Team-Triage board.
DannyH added a subscriber: DannyH.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 3 2015, 1:23 AM

I assume this would work the same in both directions? So, whichever the last mode is, that a user makes an edit in, will be saved as their sticky preference.

Jay8g added a subscriber: Jay8g.May 6 2015, 2:50 AM
He7d3r added a subscriber: He7d3r.May 6 2015, 10:42 PM

Indeed, I might want to check if VE converted correctly to the wikitext I was expecting it to use.

@DannyH I think we should do it for both. Change detection for whether they edited the wikitext box is much easier, anyway.

Sure, that's fine. I'll update the ticket.

DannyH renamed this task from VE on Flow: Don't change sticky preference if user just switches to VE for a preview to VE on Flow: Don't change sticky preference if user just switches to VE/wikitext and doesn't make a change.May 6 2015, 10:53 PM
DannyH renamed this task from VE on Flow: Don't change sticky preference if user just switches to VE/wikitext and doesn't make a change to VE on Flow: Don't change sticky preference if user just switches between VE/wikitext and doesn't make a change.
DannyH updated the task description. (Show Details)
Ltrlg added a subscriber: Ltrlg.May 15 2015, 11:19 AM