Our CI puppet manifest starts xvfb using an upstart script but it is not available on Jessie:
Error: /Stage[main]/Xvfb/Service[xvfb]: Provider upstart is not functional on this host
On Jessie slaves, we thus need to define the xvfb service via systemd.
Brandon Black pointed that Giuseppe Lavagetto wrote a puppet definition that handle that case.
No clue how it should be applied though. Operations might be able to help.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| xvfb: systemd support for Debian | operations/puppet | production | +14 -0 | |
| xvfb: switch to base::service_unit | operations/puppet | production | +8 -10 |
I'd like to see this moving forward. What is it that operations could offer to get this moving ?
https://github.com/wikimedia/operations-puppet/blob/21c72942dd7bf25dbe0759d2f867082e966bfb45/modules/base/manifests/service_unit.pp has documentation in it and already used in production examples exist in all of these files:
modules/base/manifests/service_unit.pp modules/base/spec/defines/service_unit_spec.rb modules/confd/manifests/init.pp modules/etcd/manifests/init.pp modules/graphite/manifests/carbon_c_relay.pp modules/memcached/manifests/init.pp modules/varnish/manifests/instance.pp modules/varnish/manifests/logging.pp modules/varnish/manifests/logging/statsd.pp
Anything specific that ops can help with ?
I have poked Release-Engineering-Team team mailing list about this bug and others. Need to have one of us to get his fingers in the gears and do the migration, potentially pairing with someone from ops.
Thanks for the examples @akosiaris !
Joe/Yuvi confirmed that base::service_unit has the logic to vary between Upstart and Systemd. "Just" have to provide both service files and it should sort it out for us.
Change 256643 had a related patch set uploaded (by Hashar):
xvfb: switch to base::service_unit
Change 256659 had a related patch set uploaded (by Hashar):
xvfb: systemd support for Debian
I have cherry picked https://gerrit.wikimedia.org/r/#/c/256643/ and https://gerrit.wikimedia.org/r/#/c/256659/ on the integration puppetmaster. We now have Xvfb running on Jessie slaves.
Need the changes to be merged so we can use it on Nodepool instances.