Page MenuHomePhabricator
Create Task
Maniphest T95025

C4. Fix watchlist patrolling rendering for Flow in regular watchlist (works in grouped watchlist)
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

I don't think it's actually showing patrolled edits. I think Flow is just not rendering that part of the line.

As a user who combats vandalism by patrolling recent changes to lot of pages, I want to have a clean list of watched pages, where edits patrolled by other users do not show up, so that I can focus on reviewing only unpatrolled edits.

MediaWiki's patrol feature is enabled on ~70 WMF wikis, and allows this filtering of the watchlist by means of the user preference watchlisthidepatrolled, which I keep enabled all the time. However, this feature is broken on Flow talk pages: every single comment stays in the list forever!

On the following screenshot, the only patrolled changes which appear on Special:Watchlist are the ones on Flow pages.

This was originally reported on
https://pt.wikipedia.org/w/index.php?diff=41804589

See also:

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Flowmaster+6 -0Show unpatrolled flag in watchlist and recent changes
mediawiki/coremaster+3 -2Allow ChangesList::isUnpatrolled to use different change types
Customize query in gerrit

Related Objects
Search...

Event Timeline

He7d3r created this task.Apr 3 2015, 6:14 PM
He7d3r raised the priority of this task from to Needs Triage.
He7d3r updated the task description. (Show Details)
He7d3r added projects: StructuredDiscussions, Collaboration-Team-Triage.
He7d3r added a subscriber: He7d3r.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 3 2015, 6:14 PM
He7d3r mentioned this in T94954: It is not clear what Flow's hide link is for (some users try to stop Echo notifications using it).Apr 3 2015, 6:17 PM
He7d3r added a parent task: T85540: Feed (watchlist/RC/contribs) - Flow issues (tracking).Apr 3 2015, 6:24 PM
He7d3r mentioned this in T94451: A3. Implement auto-patrolling for Flow.Apr 6 2015, 3:23 PM
EBernhardson closed this task as a duplicate of T94452: C2. Implement patrolling other people's edits in Flow.Apr 6 2015, 5:53 PM
He7d3r changed the task status from Duplicate to Declined.Apr 6 2015, 6:31 PM
He7d3r claimed this task.
He7d3r added a subscriber: Jbribeiro1.

This is not the same as that bug, since that screenshot shows patrolled edits (i.e., without the "!"mark) from @Jbribeiro1 still in the list.

• Mattflaschen-WMF reopened this task as Open.Apr 6 2015, 8:45 PM
• Mattflaschen-WMF added a subscriber: • Mattflaschen-WMF.

Where do you get that this is Declined? We're going to address all of the issues related to patrolling.

In this case, I don't think the omission of the ! actually means it's patrolled. We just haven't implemented that part of the rendering.

I'll rename this to be about patrolled rendering on watchlist, since we have one about RC, but not watchlist.

• Mattflaschen-WMF renamed this task from Unable to remove patrolled comments from Special:Watchlist on Flow pages to Fix Flow rendering of patrolling status on watchlist.Apr 6 2015, 8:46 PM
• Mattflaschen-WMF removed He7d3r as the assignee of this task.
• Mattflaschen-WMF triaged this task as Medium priority.
• Mattflaschen-WMF set Security to None.
• Mattflaschen-WMF updated the task description. (Show Details)
• Mattflaschen-WMF removed a parent task: T85540: Feed (watchlist/RC/contribs) - Flow issues (tracking).
• Mattflaschen-WMF added a parent task: T73456: Edit patrol - Flow issues (tracking).
• Mattflaschen-WMF renamed this task from Fix Flow rendering of patrolling status on watchlist to Fix watchlist patrolling status for Flow.Apr 6 2015, 8:48 PM
He7d3r added a comment.Apr 6 2015, 8:56 PM

Uops... I clicked in the wrong option. I was trying to reopen the task.

• Mattflaschen-WMF renamed this task from Fix watchlist patrolling status for Flow to Fix watchlist patrolling rendering for Flow.Apr 6 2015, 9:27 PM
In T95025#1183718, @He7d3r wrote:

Uops... I clicked in the wrong option. I was trying to reopen the task.

Oh, I see. Yeah, it's weird that's the default.

DannyH added a parent task: T99117: Turn Flow on for Catalan's Viquipèdia talk namespace.May 14 2015, 7:17 PM
jeremyb added a subscriber: jeremyb.May 21 2015, 7:57 PM
DannyH moved this task from Untriaged to Team discussion on the Collaboration-Team-Triage board.Jun 2 2015, 5:49 PM
• Mattflaschen-WMF mentioned this in T94452: C2. Implement patrolling other people's edits in Flow.Jun 2 2015, 5:50 PM
DannyH closed this task as Resolved.Jun 2 2015, 6:00 PM
DannyH claimed this task.
DannyH added a subscriber: DannyH.

Resolved by a previous patrolling ticket, this works on production.

DannyH reopened this task as Open.Jun 2 2015, 6:01 PM

Taking that back -- it works with grouped recent changes, but not with regular RC.

DannyH renamed this task from Fix watchlist patrolling rendering for Flow to Fix watchlist patrolling rendering for Flow in regular RC (works in grouped RC).Jun 2 2015, 6:02 PM
DannyH removed DannyH as the assignee of this task.
DannyH edited a custom field.
DannyH moved this task from Team discussion to Ready for next sprint on the Collaboration-Team-Triage board.
DannyH renamed this task from Fix watchlist patrolling rendering for Flow in regular RC (works in grouped RC) to Fix watchlist patrolling rendering for Flow in regular watchlist (works in grouped watchlist).Jun 2 2015, 6:04 PM
DannyH moved this task from Ready for next sprint to Sprint C (temporary for meeting) on the Collaboration-Team-Triage board.Jun 3 2015, 6:04 PM
DannyH added a project: Collaboration-Team-Sprint-C-2015-06-17.Jun 3 2015, 7:09 PM
DannyH moved this task from Sprint C (temporary for meeting) to Current workboard on the Collaboration-Team-Triage board.
DannyH renamed this task from Fix watchlist patrolling rendering for Flow in regular watchlist (works in grouped watchlist) to C4. Fix watchlist patrolling rendering for Flow in regular watchlist (works in grouped watchlist).Jun 3 2015, 7:13 PM
DannyH raised the priority of this task from Medium to High.
SBisson claimed this task.Jun 3 2015, 7:14 PM
SBisson moved this task from Sprint C - ends June 15 to In Development on the Collaboration-Team-Sprint-C-2015-06-17 board.
gerritbot added a subscriber: gerritbot.Jun 4 2015, 2:26 PM

Change 215912 had a related patch set uploaded (by Sbisson):
Show unpatrolled flag in watchlist and recent changes

https://gerrit.wikimedia.org/r/215912

gerritbot added a project: Patch-For-Review.Jun 4 2015, 2:26 PM
SBisson moved this task from In Development to Needs Review on the Collaboration-Team-Sprint-C-2015-06-17 board.Jun 4 2015, 2:29 PM
matthiasmullie moved this task from Needs Review to Code Review Started on the Collaboration-Team-Sprint-C-2015-06-17 board.Jun 5 2015, 3:31 PM
gerritbot added a comment.Jun 5 2015, 5:22 PM

Change 216131 had a related patch set uploaded (by Sbisson):
Allow ChangesList::isUnpatrolled to use different change types

https://gerrit.wikimedia.org/r/216131

gerritbot added a comment.Jun 5 2015, 7:06 PM

Change 216131 abandoned by Sbisson:
Allow ChangesList::isUnpatrolled to use different change types

Reason:
This does not make too much sense. NP patrolling for Flow is not clearly defined yet.

https://gerrit.wikimedia.org/r/216131

matthiasmullie moved this task from Code Review Started to QA Review on the Collaboration-Team-Sprint-C-2015-06-17 board.Jun 8 2015, 12:23 PM
gerritbot added a comment.Jun 8 2015, 12:25 PM

Change 215912 merged by jenkins-bot:
Show unpatrolled flag in watchlist and recent changes

https://gerrit.wikimedia.org/r/215912

Diffusion mentioned this in rMEXT3317f33d8173: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Jun 8 2015, 12:25 PM
SBisson mentioned this in rEFLW64f2ae76073b: Show unpatrolled flag in watchlist and recent changes.Jun 8 2015, 12:25 PM
Etonkovidova added a subscriber: Etonkovidova.Jun 9 2015, 9:51 PM

Checked if ! properly displayed for unpatrolled edits/created topics on http://ca.wikipedia.beta.wmflabs.org/ for Watchlist and Recent Changes - grouped/ungrouped.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Sprint-C-2015-06-17 board.Jun 9 2015, 9:52 PM
DannyH closed this task as Resolved.Jun 10 2015, 5:20 PM

works on beta

DannyH moved this task from Product Review to Done on the Collaboration-Team-Sprint-C-2015-06-17 board.Jun 10 2015, 5:20 PM
DannyH moved this task from Current workboard to Resolved on the Collaboration-Team-Triage board.Jun 11 2015, 9:20 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL