Page MenuHomePhabricator
Create Task
Maniphest T95068

When inserting new WikiGrok claims, it throws an error if the same claim already exists
Closed, ResolvedPublic
Actions

Description

Just got the following error from the WikiGrok API on my local instance:
Function: WikiGrok\\ResponseStoreDB::insertClaims
Error: 1062 Duplicate entry '9-author-add-0hjwrvbwcbk5n7yr4311xc15z1uf9m1b' for key 'wgc_unique' ()

Details

SubjectRepoBranchLines +/-
Prevent database error resulting from duplicate unique keymediawiki/extensions/WikiGrokmaster+2 -3
Customize query in gerrit

Related Objects

Event Timeline

kaldari created this task.Apr 4 2015, 12:12 AM
kaldari raised the priority of this task from to Needs Triage.
kaldari updated the task description. (Show Details)
kaldari added a project: WikiGrok.
kaldari subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 4 2015, 12:12 AM
kaldari merged a task: T95721: WikiGrok save error.Apr 13 2015, 5:46 PM
kaldari added subscribers: phuedx, • bmansurov, MaxSem.
phuedx mentioned this in T95874: Deploy the latest version of WikiGrok (0.2? 0.3?).Apr 13 2015, 5:50 PM
phuedx added a project: Mobile-Web-Sprint-45-Snakes-On-A-Plane.Apr 13 2015, 6:40 PM
phuedx set Security to None.
phuedx added a comment.Apr 13 2015, 7:16 PM

Currently, ResponseStoreDB#store is treating claims as equal even if their actions differ. However, Claim#equals doesn't do this.

You should be able to reproduce this by submitting a "None of these" answer to WikiGrok – all claims have the "ignore" action – and then submitting a WikiGrok answer with one of the tags selected – the claim will have the "add" action.

phuedx claimed this task.Apr 13 2015, 7:55 PM
phuedx moved this task from Needs Analysis to Doing on the Mobile-Web-Sprint-45-Snakes-On-A-Plane board.
phuedx removed phuedx as the assignee of this task.Apr 13 2015, 8:22 PM
phuedx moved this task from Doing to Needs Analysis on the Mobile-Web-Sprint-45-Snakes-On-A-Plane board.
kaldari claimed this task.Apr 13 2015, 9:07 PM
kaldari moved this task from Needs Analysis to Doing on the Mobile-Web-Sprint-45-Snakes-On-A-Plane board.
gerritbot subscribed.Apr 13 2015, 11:08 PM

Change 203989 had a related patch set uploaded (by Kaldari):
Prevent database error resulting from duplicate unique key

https://gerrit.wikimedia.org/r/203989

gerritbot added a project: Patch-For-Review.Apr 13 2015, 11:08 PM
kaldari added a comment.Apr 13 2015, 11:11 PM

Actually it looks like it was handling different action types fine (the claim key included the action). The problem was that it wasn't looking at database claim entries for statuses other than "new", so as soon as a claim reached the aggregation threshold and was applied or ignored it would then be subject to key duplication.

kaldari moved this task from Doing to Code Review on the Mobile-Web-Sprint-45-Snakes-On-A-Plane board.Apr 13 2015, 11:16 PM
gerritbot added a comment.Apr 14 2015, 10:49 AM

Change 203989 merged by jenkins-bot:
Prevent database error resulting from duplicate unique key

https://gerrit.wikimedia.org/r/203989

phuedx mentioned this in rEWGRd5a193027ee8: Prevent database error resulting from duplicate unique key.Apr 14 2015, 10:49 AM
kaldari mentioned this in rMEXTdc2bc1e4b14f: Updated mediawiki/extensions Project: mediawiki/extensions/WikiGrok….Apr 14 2015, 10:49 AM
phuedx removed a project: Patch-For-Review.Apr 14 2015, 10:53 AM
phuedx moved this task from Code Review to Done on the Mobile-Web-Sprint-45-Snakes-On-A-Plane board.
phuedx closed this task as Resolved.Apr 14 2015, 2:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits