Page MenuHomePhabricator

OAuth authorization dialog text specifies the grant scope (current wiki / all wikis) in a confusing way
Open, LowPublic

Description

When an application is approved for all wikis of a wiki family, the text of the authorization dialog is

in order to complete your request, <application> needs permission to perform the following actions on your behalf on all projects of this site:

"All projects on this site" (mwoauth-consumer-allwikis) is confusing since projects tend to be separate sites.

Event Timeline

TheDJ raised the priority of this task from to Needs Triage.
TheDJ updated the task description. (Show Details)
TheDJ subscribed.
Ricordisamoa renamed this task from Oauth grant for Phabricator can be confusing to users to OAuth grant for Phabricator can be confusing to users.Apr 6 2015, 9:15 AM
Ricordisamoa set Security to None.
Ricordisamoa subscribed.

Mmm... I believe this is a duplicate of an existing task, although I cannot find it. :/

We could reword "All projects on this site" into: "All sister projects connected to {{SITENAME}}"

Mmm... I believe this is a duplicate of an existing task, although I cannot find it. :/

T598: MediaWiki OAuth dialog text is unclear and sounds more scary than it is, which was marked as duplicate of T91825: Improve text of OAuth authorization dialog. Since there is nothing Phabricator specific in this dialog, I think we should merge this task to T91825 as well.

Tgr renamed this task from OAuth grant for Phabricator can be confusing to users to OAuth authorization dialog test specifies the grant scope (current wiki / all wikis) in a confusing way.Jun 29 2015, 10:59 PM
Tgr reopened this task as Open.
Tgr triaged this task as Medium priority.
Tgr updated the task description. (Show Details)

Ideally this should say something like "all Wikimedia wikis" or "all Wikimedia projects" but not sure to do that in a generic way.

CentralAuth just uses a message default value (centralauth-groupname -> "The Wikimedia Foundation") which non-WMF projects are expected to override, but then CentralAuth was never designed to be actually used by non-WMF projects.

Aklapper lowered the priority of this task from Medium to Low.Feb 9 2016, 10:24 PM

Blocked by T91825: Improve text of OAuth authorization dialog with 'normal' priority assigned to Tgr; hence setting priority here to low.

Tgr renamed this task from OAuth authorization dialog test specifies the grant scope (current wiki / all wikis) in a confusing way to OAuth authorization dialog text specifies the grant scope (current wiki / all wikis) in a confusing way.Mar 7 2017, 4:40 AM
Tgr added a project: Voice & Tone.
matmarex subscribed.
In T95133#1416346, @Tgr wrote:

Ideally this should say something like "all Wikimedia wikis" or "all Wikimedia projects" but not sure to do that in a generic way.

CentralAuth just uses a message default value (centralauth-groupname -> "The Wikimedia Foundation") which non-WMF projects are expected to override, but then CentralAuth was never designed to be actually used by non-WMF projects.

We could just override the messages in the WikimediaMessages extension.

Add them to the list here: https://gerrit.wikimedia.org/g/mediawiki/extensions/WikimediaMessages/+/d54db64724d36e3b82ff5d3ab9541c3ec6785b34/includes/Hooks.php#121

And copy the messages, with a "wikimedia-" prefix, and changing the text appropriately (I suppose it should say "Wikimedia wikis" instead of "all projects of this site"?), here: https://gerrit.wikimedia.org/g/mediawiki/extensions/WikimediaMessages/+/d54db64724d36e3b82ff5d3ab9541c3ec6785b34/i18n/wikimediaoverrides/en.json

Here's an example change that did the same thing for another extension's messages: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaMessages/+/652557