Page MenuHomePhabricator
Create Task
Maniphest T95168

[Task] Remove calls to getIsRawMode() in Wikibase, and calls to setRawMode() in tests
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

this blocks work on the core api code and might not be trivial.

Details

SubjectRepoBranchLines +/-
Remove final use of setRawMode in Wikibasemediawiki/extensions/Wikibasemaster+0 -0
API BREAKING CHANGE - Remove rawMode usemediawiki/extensions/Wikibasemaster+617 -870
APIPOKE - Return for-language key for non raw fallbacksmediawiki/extensions/Wikibasemaster+16 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

aude created this task.Apr 6 2015, 2:31 PM
aude raised the priority of this task from to Needs Triage.
aude updated the task description. (Show Details)
aude added a project: MediaWiki-extensions-WikibaseRepository.
aude subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2015, 2:31 PM
aude added a project: Wikidata.Apr 6 2015, 2:32 PM
aude set Security to None.
aude added a parent task: T91073: Update Wikidata for ApiResult rewrite.
aude mentioned this in T92970: Replace ApiResult::setRawMode use in EntityDataSerializationService.
Anomie subscribed.Apr 6 2015, 3:54 PM
• ksmith subscribed.Apr 6 2015, 4:18 PM
Anomie added a parent task: T96596: Add wfDeprecated() to deprecated ApiResult methods.Apr 20 2015, 6:37 PM
aude triaged this task as High priority.Apr 23 2015, 12:33 PM
aude updated the task description. (Show Details)
JanZerebecki moved this task from incoming to ready to go on the Wikidata board.May 16 2015, 10:38 PM
Addshore renamed this task from Remove calls to getIsRawMode() in ResultBuilder and GetEntities, and calls to setRawMode() in tests to Remove calls to getIsRawMode() in Wikibase, and calls to setRawMode() in tests.Jul 9 2015, 3:52 PM
• ksmith unsubscribed.Jul 9 2015, 4:56 PM
Addshore subscribed.Jul 15 2015, 11:42 AM

I am looking at this now, bit of re factoring to do first though

Addshore claimed this task.Jul 29 2015, 9:36 AM

All of the re factoring to make this easier is now done.
Now just to make a few API breaks and pokes in order to be able to totally remove our usage of getIsRawMode etc.

gerritbot subscribed.Jul 29 2015, 9:44 AM

Change 227667 had a related patch set uploaded (by Addshore):
APIPOKE - Return for-language key for non raw fallbacks

https://gerrit.wikimedia.org/r/227667

gerritbot added a project: Patch-For-Review.Jul 29 2015, 9:44 AM
JanZerebecki added a project: Wikidata-Sprint-2015-06-30.Jul 31 2015, 12:17 AM
JanZerebecki moved this task from Backlog to Doing on the Wikidata-Sprint-2015-06-30 board.
Tobi_WMDE_SW edited a custom field.Aug 5 2015, 9:05 AM
gerritbot added a comment.Aug 5 2015, 10:22 AM

Change 227667 merged by jenkins-bot:
APIPOKE - Return for-language key for non raw fallbacks

https://gerrit.wikimedia.org/r/227667

Diffusion mentioned this in rMEXT2c5d05725680: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Aug 5 2015, 10:22 AM
Addshore mentioned this in rEWBAf93df1c25589: APIPOKE - Return for-language key for non raw fallbacks.Aug 5 2015, 10:22 AM
daniel subscribed.Aug 5 2015, 3:14 PM

Seems like ResultBuilder.php is still using getIsRawMode quite a bit. ApiHelperFactoryTest.php mocks that method (needlessly?). ApiXmlFormatTest.php uses setRawMode().

aude renamed this task from Remove calls to getIsRawMode() in Wikibase, and calls to setRawMode() in tests to [Task] Remove calls to getIsRawMode() in Wikibase, and calls to setRawMode() in tests.Aug 13 2015, 1:39 PM
Addshore added a comment.Aug 19 2015, 9:40 AM

Basically this will all come down to a breaking change to remove the uses.
But we will probably also have to poke core slightly (i'll explain why when I get back to this)

Addshore added a comment.Aug 19 2015, 5:21 PM

Related: P1902
and https://gerrit.wikimedia.org/r/#/c/227686/

WIP

gerritbot added a comment.Aug 20 2015, 11:17 AM

Change 227686 had a related patch set uploaded (by Addshore):
WIP API BREAK

https://gerrit.wikimedia.org/r/227686

Addshore moved this task from ready to go to in progress on the Wikidata board.Aug 20 2015, 5:51 PM
Addshore added a project: Wikidata-Sprint-2015-08-18.
Addshore moved this task from Backlog to Review on the Wikidata-Sprint-2015-08-18 board.
Addshore added a parent task: T109969: Wikidata breaking API changes (tracking).Aug 23 2015, 9:40 AM
gerritbot added a comment.Aug 27 2015, 12:06 PM

Change 234258 had a related patch set uploaded (by Addshore):
Remove final use of setRawMode in Wikibasei

https://gerrit.wikimedia.org/r/234258

gerritbot added a comment.Aug 27 2015, 1:52 PM

Change 227686 merged by jenkins-bot:
API BREAKING CHANGE - Remove rawMode use

https://gerrit.wikimedia.org/r/227686

Addshore mentioned this in rEWBAd5fbc83fc07a: API BREAKING CHANGE - Remove rawMode use.Aug 27 2015, 1:52 PM
Diffusion mentioned this in rMEXT042f0daeb1f8: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Aug 27 2015, 1:52 PM
daniel closed this task as Resolved.Aug 27 2015, 1:55 PM
daniel moved this task from Review to Done on the Wikidata-Sprint-2015-08-18 board.

merged

Multichill mentioned this in T110559: Make sure that Pywikibot still works with new api data output format.Aug 27 2015, 5:50 PM
Multichill added a parent task: T110559: Make sure that Pywikibot still works with new api data output format.
Ricordisamoa subscribed.Sep 4 2015, 5:22 AM
gerritbot added a comment.Sep 30 2015, 10:40 PM

Change 234258 abandoned by Addshore:
Remove final use of setRawMode in Wikibase

Reason:
This is a null change now as its already done

https://gerrit.wikimedia.org/r/234258

Ricordisamoa removed a project: Patch-For-Review.Sep 30 2015, 10:45 PM
Ricordisamoa removed a subscriber: gerritbot.
Anomie mentioned this in T104786: Support formatversion=2 in SiteMatrix API.Oct 20 2015, 3:53 PM
Ricordisamoa mentioned this in T118676: HoverCards: JS error for properties without description.Nov 17 2015, 9:53 AM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM
Restricted Application added a project: User-Addshore. · View Herald TranscriptOct 16 2020, 5:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL