Page MenuHomePhabricator

Add a surrogate primary key to flow_wiki_ref and flow_ext_ref
Closed, DuplicatePublic

Description

Per springle in T92979 we need to add a surrogate primary key to ensure online schema changes can be performed in the future:

So these tables no longer have primary keys?
That's ok for now, but it will be problematic in the future as it limits our ability to perform online schema changes.
If possible, add a surrogate primary key.

Event Timeline

EBernhardson raised the priority of this task from to Needs Triage.
EBernhardson updated the task description. (Show Details)
EBernhardson added a subscriber: EBernhardson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2015, 6:47 PM

@EBernhardson: Please associate projects to tasks, otherwise nobody will find such tasks when searching.
Is this StructuredDiscussions code base territory? And/or should T51188 be blocked by this task?

@EBernhardson: Please associate projects to tasks, otherwise nobody will find such tasks when searching.
Is this StructuredDiscussions code base territory? And/or should T51188 be blocked by this task?

EBernhardson added a comment.EditedApr 14 2015, 9:35 PM

hmm, it looks like how i end up with these tasks not assigned to a project is i type the word 'flow' into the box and then click 'add Ticket' whereas the interface wants me to select something from the auto-complete drop down, and throws away my typing. Perhaps phabricator needs a warning or popup that says its about to throw away something i typed. Filed as T96086.

This isn't a schema-change yet, adding flow project.

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 14 2015, 9:35 PM
EBernhardson triaged this task as Normal priority.Apr 17 2015, 5:54 PM
EBernhardson added a project: Technical-Debt.