Page MenuHomePhabricator
Create Task
Maniphest T95246

Link context item appears when selecting image whose entire caption is a link
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

1.Insert an image
2.Insert a link in the media Setting dialog and click on Insert
3.Now select the image and when the context menu for the link appears from outside, click on the Edit button on it
4.Change the link target to something else and click on "Done"

Observed Result:
The change in the link does not get applied

Screen_Shot_2015-04-06_at_4.27.31_PM.png (365×217 px, 31 KB)

Screen_Shot_2015-04-06_at_4.27.37_PM.png (354×254 px, 48 KB)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Skip ignoreChildren nodes in getAnnotatedRangeFromSelectionCatropeVisualEditor/VisualEditormaster+35 -5
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Apr 6 2015, 11:28 PM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2015, 11:28 PM
Ryasmeen triaged this task as High priority.Apr 6 2015, 11:28 PM
Ryasmeen added a project: VisualEditor.
Ryasmeen set Security to None.
Catrope renamed this task from The link inside media settings dialog does not get changed when its been modified from the outer context menu to Link context item appears when selecting image whose entire caption is a link.Apr 7 2015, 12:05 AM
Catrope added a project: VisualEditor 2014/15 Q4 blockers.
Catrope subscribed.Apr 7 2015, 12:10 AM

That inspector shouldn't even be there. Seems to be because getAnnotationsFromRange() doesn't take ignoreChildren into account?

Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.Apr 7 2015, 4:17 PM
Jdforrester-WMF moved this task from TR6: Visual diffs to Planned Maintenance on the VisualEditor board.
Jdforrester-WMF moved this task from Planned Maintenance to TR6: Visual diffs on the VisualEditor board.
gerritbot subscribed.Apr 7 2015, 11:57 PM

Change 202624 had a related patch set uploaded (by Catrope):
Skip ignoreChildren nodes in getAnnotatedRangeFromSelection

https://gerrit.wikimedia.org/r/202624

gerritbot added a project: Patch-For-Review.Apr 7 2015, 11:57 PM
Jdforrester-WMF added a project: VisualEditor-DataModel.Apr 8 2015, 6:15 PM
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from Nominated to Backlog on the VisualEditor 2014/15 Q4 blockers board.Apr 8 2015, 7:24 PM
Jdforrester-WMF moved this task from Backlog to Doing on the VisualEditor 2014/15 Q4 blockers board.Apr 8 2015, 7:42 PM
gerritbot added a comment.Apr 8 2015, 10:01 PM

Change 202624 merged by jenkins-bot:
Skip ignoreChildren nodes in getAnnotatedRangeFromSelection

https://gerrit.wikimedia.org/r/202624

Catrope mentioned this in rGVED10b1ae6472e8: Skip ignoreChildren nodes in getAnnotatedRangeFromSelection.Apr 8 2015, 10:01 PM
Jdforrester-WMF closed this task as Resolved.Apr 8 2015, 10:06 PM
Jdforrester-WMF assigned this task to Catrope.
Jdforrester-WMF edited projects, added: WMF-deploy-2015-04-15_(1.26wmf2); removed: Patch-For-Review.
Jdforrester-WMF moved this task from Doing to Done on the VisualEditor 2014/15 Q4 blockers board.Apr 8 2015, 10:10 PM
Jdforrester-WMF moved this task from TR6: Visual diffs to FY 18-19 Q3/Q4 on the VisualEditor board.Apr 16 2015, 9:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits