Page MenuHomePhabricator
Create Task
Maniphest T95252

Lets not have "Delete" option enabled when the only item inside Transclusion Dialog is "Add template" , as that cannot be deleted
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Recently we tweaked the behavior inside the tranclusion dialog in a way that user wont get stranded by deleting everything inside the dialog.It will always have the "Add a template" textbox prompted.(https://phabricator.wikimedia.org/T52281)
Now we still have the trash icon on both the left and right panel enabled, clicking on which does nothing, as you cannot empty the dialog.
So can we just disable the Trash button here?

Screen_Shot_2015-04-06_at_5.00.49_PM.png (508×701 px, 34 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Template placeholder: Don't show delete button if we're the only transclusion partmediawiki/extensions/VisualEditormaster+4 -0
Stop removal of only template placeholder from transclusionmediawiki/extensions/VisualEditormaster+7 -2
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Apr 7 2015, 12:01 AM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 7 2015, 12:01 AM
Ryasmeen updated the task description. (Show Details)Apr 7 2015, 12:02 AM
Ryasmeen set Security to None.

Also trash icon is red on the right side panel and black on the left side

Krenair claimed this task.Jul 25 2015, 1:46 PM
gerritbot subscribed.Jul 25 2015, 1:47 PM

Change 226975 had a related patch set uploaded (by Alex Monk):
Stop removal of only template placeholder from transclusion

https://gerrit.wikimedia.org/r/226975

gerritbot added a project: Patch-For-Review.Jul 25 2015, 1:47 PM
Jdforrester-WMF triaged this task as Low priority.Jul 30 2015, 5:33 PM
Jdforrester-WMF added a project: VisualEditor-MediaWiki-Templates.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF closed this task as Resolved.Jul 31 2015, 9:57 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF edited a custom field.
gerritbot added a comment.Jul 31 2015, 9:59 PM

Change 226975 merged by jenkins-bot:
Stop removal of only template placeholder from transclusion

https://gerrit.wikimedia.org/r/226975

Krenair mentioned this in rEVED8ae71e205a16: Stop removal of only template placeholder from transclusion.Jul 31 2015, 9:59 PM
• Forrestbot added a project: WMF-deploy-2015-08-04_(1.26wmf17).Jul 31 2015, 10:00 PM
Ryasmeen reopened this task as Open.Aug 6 2015, 5:57 AM

We still have the red trash icon on the right panel, do we want it like this?

Screen Shot 2015-08-05 at 10.55.53 PM.png (504×701 px, 31 KB)

gerritbot added a comment.Aug 11 2015, 5:26 PM

Change 230814 had a related patch set uploaded (by Alex Monk):
Template placeholder: Don't show delete button if we're the only transclusion part

https://gerrit.wikimedia.org/r/230814

gerritbot added a project: Patch-For-Review.Aug 11 2015, 5:26 PM
Jdforrester-WMF moved this task from TR1: Releases to TR0: Interrupt on the VisualEditor board.Aug 26 2015, 1:35 AM
gerritbot added a comment.Sep 21 2015, 5:27 PM

Change 230814 merged by jenkins-bot:
Template placeholder: Don't show delete button if we're the only transclusion part

https://gerrit.wikimedia.org/r/230814

Jdforrester-WMF mentioned this in rEVED2d46e57709d4: Template placeholder: Don't show delete button if we're the only transclusion….Sep 21 2015, 5:28 PM
Krenair closed this task as Resolved.Sep 21 2015, 5:33 PM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-22_(1.26wmf24).Sep 21 2015, 6:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits