Page MenuHomePhabricator
Create Task
Maniphest T95353

database side truncated comments not shown in history or diff
Closed, ResolvedPublic
Actions

Description

The diff https://ru.wikipedia.org/w/index.php?title=Википедия:Именование_статей/Иноязычные_названия&diff=prev&oldid=65843747 has a comment which was truncated on database side to be 255 bytes but it is not shown in the gui.

With T85700 an application side truncation was added for new revisions, but there need a way to handle the existing bad truncated comments.

The problem is that htmspecialchars does not allow half bytes to be processed and is returning null, which than is shown as empty string.

The api returns a placeholder utf character \ufffd
https://ru.wikipedia.org/w/api.php?action=query&prop=revisions&revids=65843747 instead of nothing.

Details

SubjectRepoBranchLines +/-
Replace invalid UTF-8 sequences with U+FFFD in edit summariesmediawiki/coremaster+3 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Umherirrender created this task.Apr 7 2015, 9:52 PM
Umherirrender raised the priority of this task from to Needs Triage.
Umherirrender updated the task description. (Show Details)
Umherirrender added a project: MediaWiki-Page-diffs.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 7 2015, 9:52 PM
Umherirrender mentioned this in T85700: Long edit comments get entirely removed instead of truncated (error in cutting multibyte chars?).Apr 7 2015, 9:53 PM
Liuxinyu970226 added a subscriber: Liuxinyu970226.Apr 8 2015, 1:02 AM
MBH added a subscriber: MBH.Apr 8 2015, 3:02 AM
Umherirrender mentioned this in T97883: Reject summary for FlaggedRevs gets cut of badly for multibyte chars.May 2 2015, 7:45 AM
Umherirrender added a parent task: T85700: Long edit comments get entirely removed instead of truncated (error in cutting multibyte chars?).May 2 2015, 6:12 PM
Aklapper triaged this task as Low priority.Jun 16 2015, 2:13 PM
Liuxinyu970226 removed a subscriber: Liuxinyu970226.Jun 29 2015, 11:18 PM
TTO claimed this task.Jan 1 2017, 4:04 AM
TTO added a subscriber: TTO.

You can reproduce this on your local MW installation by running the following SQL query:

UPDATE `revision` SET `rev_comment`=FROM_BASE64("0JfQsNGJ0LjRidC10L3QsCDQktC40LrQuNC/0LXQtNC40Y860JjQvNC10L3QvtCy0LDQvdC40LUg0YHRgtCw0YLQtdC5L9CY0L3QvtGP0LfRi9GH0L3Ri9C1INC90LDQt9Cy0LDQvdC40Y86INC/0L7QstGC0L7RgNGP0Y7RidC40LXRgdGPINC90LXQutC+0L3RgdC10L3RgdGD0YHQvdGL0LUg0L/RgNCw0LLQutC4IChb0KDQtdC00LDQutGC0LjRgNC+0LLQsNC90LjQtT3RgtC+0LvRjNC60L4g0LDQstGC0L7Qv9C+0LTRgtCy0LXRgNC20LTRkdC90L3R") WHERE `rev_id`=XXX
gerritbot added a subscriber: gerritbot.Jan 1 2017, 4:06 AM

Change 329814 had a related patch set uploaded (by TTO):
Replace invalid UTF-8 sequences with U FFFD in edit summaries

https://gerrit.wikimedia.org/r/329814

gerritbot added a project: Patch-For-Review.Jan 1 2017, 4:06 AM
matmarex closed this task as Resolved.Jan 4 2017, 9:22 PM
matmarex removed a project: Patch-For-Review.
gerritbot added a comment.Jan 4 2017, 9:32 PM

Change 329814 merged by jenkins-bot:
Replace invalid UTF-8 sequences with U FFFD in edit summaries

https://gerrit.wikimedia.org/r/329814

ReleaseTaggerBot added projects: MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)).Jan 4 2017, 10:00 PM
Aklapper added a project: MediaWiki-Page-history.Sep 20 2019, 7:48 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL