Page MenuHomePhabricator
Create Task
Maniphest T95406

[Task] browser tests for old revisions of Wikibase item pages to check there are no edit links
Open, LowestPublic3 Story Points
Actions

Description

Create browser tests for old revisions of Wikibase item pages to check there are no edit links. (see T95405 for when this broke)

WHEN a page already exists
AND a user makes a new revisions of that page
AND the user navigates to the previous revisions
THEN no edit links should be visible on the page

Right now we only want to bother creating a test for Item pages.

Related Objects
Search...

Event Timeline

aude created this task.Apr 8 2015, 10:16 AM
aude raised the priority of this task from to Needs Triage.
aude updated the task description. (Show Details)
aude added projects: MediaWiki-extensions-WikibaseRepository, Wikidata.
aude added subscribers: aude, Aklapper, Tobi_WMDE_SW.
aude mentioned this in T95405: edit links are displayed on old revisions.Apr 8 2015, 11:56 AM
aude set Security to None.
aude added a subscriber: WMDE-Fisch.
Lydia_Pintscher triaged this task as Normal priority.Apr 10 2015, 1:38 PM
Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.
aude renamed this task from browser tests for old revisions of Wikibase item pages to check there are no edit links to [Task] browser tests for old revisions of Wikibase item pages to check there are no edit links.Aug 13 2015, 9:12 PM
Addshore lowered the priority of this task from Normal to Lowest.Feb 21 2019, 10:28 AM
Addshore moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.
Addshore updated the task description. (Show Details)Feb 21 2019, 10:31 AM
alaa_wmde set the point value for this task to 3.Mar 12 2019, 4:09 PM
noarave claimed this task.May 16 2019, 10:20 AM
Restricted Application added a project: User-Noarave. · View Herald TranscriptMay 16 2019, 10:20 AM
gerritbot added a comment.Jul 1 2019, 8:40 AM

Change 519976 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[mediawiki/extensions/Wikibase@master] Browser test for old revisions of Wikibase item pages to check there are no edit links

https://gerrit.wikimedia.org/r/519976

gerritbot added a comment.Jul 1 2019, 11:32 AM

Change 519976 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Browser test for old revisions of Wikibase item pages to check there are no edit links

https://gerrit.wikimedia.org/r/519976

alaa_wmde moved this task from in progress to needs discussion or investigation on the Wikidata board.Jul 29 2019, 12:38 PM
alaa_wmde removed a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞).
alaa_wmde added a subscriber: alaa_wmde.

We want to re-evaluate whether a browser test here is the right thing to do, before we try again to make the test less flaky. Test was skipped for flakiness T227121: Browser test fails with "old revisions do not have an edit link" blocking merges in Minerva skin

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL