Page MenuHomePhabricator
Create Task
Maniphest T95415

Increase test coverage of table support
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

TableMatrix, TableAction should be easy to do.

Details

SubjectRepoBranchLines +/-
Add tests for TableAction#changeStyle and TableAction#captionVisualEditor/VisualEditormaster+76 -1
Add test for TableAction#deleteVisualEditor/VisualEditormaster+76 -2
Test TableAction#merge when full rows/cols selectedVisualEditor/VisualEditormaster+44 -0
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Apr 8 2015, 11:29 AM
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added projects: VisualEditor, Technical-Debt.
Esanders subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 8 2015, 11:29 AM
Jdforrester-WMF triaged this task as Medium priority.Apr 8 2015, 11:30 AM
Jdforrester-WMF added a project: VisualEditor-Tables.
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.
gerritbot subscribed.Apr 8 2015, 11:54 PM

Change 202945 had a related patch set uploaded (by Catrope):
Add test for TableAction#delete (whole table)

https://gerrit.wikimedia.org/r/202945

gerritbot added a project: Patch-For-Review.Apr 8 2015, 11:54 PM
gerritbot added a comment.Apr 9 2015, 10:22 AM

Change 203016 had a related patch set uploaded (by Esanders):
Test TableAction#merge when full rows/cols selected

https://gerrit.wikimedia.org/r/203016

gerritbot added a comment.Apr 9 2015, 10:41 AM

Change 203022 had a related patch set uploaded (by Esanders):
Add tests for TableAction#changeStyle and TableAction#caption

https://gerrit.wikimedia.org/r/203022

gerritbot added a comment.Apr 9 2015, 11:47 AM

Change 203016 merged by jenkins-bot:
Test TableAction#merge when full rows/cols selected

https://gerrit.wikimedia.org/r/203016

Esanders mentioned this in rGVED12eda5dad9fc: Test TableAction#merge when full rows/cols selected.Apr 9 2015, 11:48 AM
gerritbot added a comment.Apr 9 2015, 5:25 PM

Change 202945 merged by jenkins-bot:
Add test for TableAction#delete

https://gerrit.wikimedia.org/r/202945

Esanders mentioned this in rGVED06bcc9e0332a: Add test for TableAction#delete.Apr 9 2015, 5:26 PM
gerritbot added a comment.Apr 9 2015, 5:30 PM

Change 203022 merged by jenkins-bot:
Add tests for TableAction#changeStyle and TableAction#caption

https://gerrit.wikimedia.org/r/203022

Esanders mentioned this in rGVED2ac1ae14e4c5: Add tests for TableAction#changeStyle and TableAction#caption.Apr 9 2015, 5:31 PM
Jdforrester-WMF removed a project: Patch-For-Review.Jul 15 2015, 7:58 PM
Esanders moved this task from Backlog to Data model on the VisualEditor-Tables board.Jan 31 2016, 3:09 PM
Danny_B moved this task from Unsorted to Test coverage on the Technical-Debt board.Apr 21 2016, 8:57 PM
Jdforrester-WMF closed this task as Resolved.Aug 22 2016, 5:53 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF added a project: MW-1.28-release (WMF-deploy-2016-08-23_(1.28.0-wmf.16)).
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from Freezer to TR0: Interrupt on the VisualEditor board.Aug 22 2016, 5:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL