Page MenuHomePhabricator
Create Task
Maniphest T95466

Saved edits are displayed only after additional page refresh
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

  1. Open VE in beta
  2. Make some edits - and click Save.
  3. The saved page(in 'Read' mode) won't display the edits.
  4. Switch to VE - the edits are dispalyed.

'View history' will record correctly all saved edits and correctly display the updated page. The timestamp in the footer will be also updated correctly.

Details

SubjectRepoBranchLines +/-
ApiParse: Replace isCurrent() check with getLatest() comparisonmediawiki/corewmf/1.25wmf24+4 -1
ApiParse: Replace isCurrent() check with getLatest() comparisonmediawiki/coremaster+4 -1
ApiParse: Replace isCurrent() check with getLatest() comparisonmediawiki/corewmf/1.26wmf1+4 -1
Explicitly pass oldid to ApiParse after savingmediawiki/extensions/VisualEditorwmf/1.25wmf24+10 -9
Explicitly pass oldid to ApiParse after savingmediawiki/extensions/VisualEditorwmf/1.26wmf1+10 -9
Explicitly pass oldid to ApiParse after savingmediawiki/extensions/VisualEditormaster+10 -9
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Apr 8 2015, 7:46 PM
Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added a project: VisualEditor.
Etonkovidova subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 8 2015, 7:46 PM
Catrope mentioned this in T94367: Mysterious missingrev failure during save.Apr 8 2015, 8:02 PM
gerritbot subscribed.Apr 8 2015, 8:24 PM

Change 202911 had a related patch set uploaded (by Catrope):
Explicitly pass oldid to ApiParse after saving

https://gerrit.wikimedia.org/r/202911

gerritbot added a project: Patch-For-Review.Apr 8 2015, 8:24 PM
gerritbot added a comment.Apr 8 2015, 9:02 PM

Change 202911 merged by jenkins-bot:
Explicitly pass oldid to ApiParse after saving

https://gerrit.wikimedia.org/r/202911

Catrope mentioned this in rEVED25c718bc9616: Explicitly pass oldid to ApiParse after saving.Apr 8 2015, 9:03 PM
Jdforrester-WMF renamed this task from Betalabs: the saved edits are displayed after additional page refresh to Saved edits are displayed only after additional page refresh.Apr 8 2015, 9:03 PM
Jdforrester-WMF assigned this task to Catrope.
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF edited projects, added VisualEditor 2014/15 Q4 blockers, VisualEditor-MediaWiki, WMF-deploy-2015-04-15_(1.26wmf2); removed Patch-For-Review.
Jdforrester-WMF set Security to None.
gerritbot added a comment.Apr 8 2015, 9:12 PM

Change 202920 had a related patch set uploaded (by Catrope):
Explicitly pass oldid to ApiParse after saving

https://gerrit.wikimedia.org/r/202920

gerritbot added a project: Patch-For-Review.Apr 8 2015, 9:12 PM

Change 202921 had a related patch set uploaded (by Catrope):
Explicitly pass oldid to ApiParse after saving

https://gerrit.wikimedia.org/r/202921

gerritbot added a comment.Apr 8 2015, 10:07 PM

Change 202931 had a related patch set uploaded (by Catrope):
ApiParse: Replace isCurrent() check with getLatest() comparison

https://gerrit.wikimedia.org/r/202931

Jdforrester-WMF added projects: WMF-deploy-2015-04-01_(1.25wmf24), WMF-deploy-2015-04-08_(1.26wmf1).Apr 8 2015, 10:11 PM
gerritbot added a comment.Apr 8 2015, 10:34 PM

Change 202931 had a related patch set uploaded (by Catrope):
ApiParse: Replace isCurrent() check with getLatest() comparison

https://gerrit.wikimedia.org/r/202931

gerritbot added a comment.Apr 8 2015, 10:49 PM

Change 202931 merged by jenkins-bot:
ApiParse: Replace isCurrent() check with getLatest() comparison

https://gerrit.wikimedia.org/r/202931

gerritbot added a comment.Apr 8 2015, 10:49 PM

Change 202940 had a related patch set uploaded (by Catrope):
ApiParse: Replace isCurrent() check with getLatest() comparison

https://gerrit.wikimedia.org/r/202940

Catrope mentioned this in rMW015c90fbf987: ApiParse: Replace isCurrent() check with getLatest() comparison.Apr 8 2015, 10:49 PM
gerritbot added a comment.Apr 8 2015, 10:49 PM

Change 202941 had a related patch set uploaded (by Catrope):
ApiParse: Replace isCurrent() check with getLatest() comparison

https://gerrit.wikimedia.org/r/202941

gerritbot added a comment.Apr 8 2015, 10:53 PM

Change 202920 merged by jenkins-bot:
Explicitly pass oldid to ApiParse after saving

https://gerrit.wikimedia.org/r/202920

gerritbot added a comment.Apr 8 2015, 10:53 PM

Change 202921 merged by jenkins-bot:
Explicitly pass oldid to ApiParse after saving

https://gerrit.wikimedia.org/r/202921

Catrope mentioned this in rEVEDdfbd5d278b61: Explicitly pass oldid to ApiParse after saving.Apr 8 2015, 10:53 PM
Catrope mentioned this in rEVED4debb333f4f2: Explicitly pass oldid to ApiParse after saving.
gerritbot added a comment.Apr 8 2015, 11:02 PM

Change 202940 merged by jenkins-bot:
ApiParse: Replace isCurrent() check with getLatest() comparison

https://gerrit.wikimedia.org/r/202940

Catrope mentioned this in rMWd3838b4bc1f6: ApiParse: Replace isCurrent() check with getLatest() comparison.Apr 8 2015, 11:03 PM
gerritbot added a comment.Apr 8 2015, 11:08 PM

Change 202941 merged by jenkins-bot:
ApiParse: Replace isCurrent() check with getLatest() comparison

https://gerrit.wikimedia.org/r/202941

Catrope mentioned this in rMWcd7df8c937f3: ApiParse: Replace isCurrent() check with getLatest() comparison.Apr 8 2015, 11:09 PM
Catrope added a comment.Apr 8 2015, 11:46 PM

Fixes for this have been merged into master, backported to wmf24 and wmf1, and deployed.

Catrope closed this task as Resolved.Apr 8 2015, 11:47 PM
Etonkovidova added a comment.Apr 8 2015, 11:49 PM

Checked - seems to be fine everywhere.

Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q4 blockers board.Apr 9 2015, 10:19 PM
Jdforrester-WMF edited a custom field.
Jdforrester-WMF removed a project: Patch-For-Review.Apr 15 2015, 7:35 PM
Jdforrester-WMF moved this task from To Triage to FY 18-19 Q3/Q4 on the VisualEditor board.Apr 17 2015, 11:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL