Page MenuHomePhabricator

Remove reference superscripts in share a fact cards.
Closed, ResolvedPublic2 Estimated Story Points

Assigned To
Authored By
Vibhabamba
Apr 8 2015, 8:59 PM
Referenced Files
F161653: IMG_8629.PNG
May 7 2015, 8:00 PM
F161651: IMG_8630.PNG
May 7 2015, 8:00 PM
F161654: IMG_8627.PNG
May 7 2015, 8:00 PM
F161652: IMG_8628.PNG
May 7 2015, 8:00 PM
F161256: hillary screenshot.png
May 6 2015, 7:20 PM
F110197: IMG_8456.PNG
Apr 8 2015, 8:59 PM

Description

The current reference superscript is rendered like normal text.
Also superscripts aren't actionable in the share a fact cards.
Have we already tried to eliminate them?

IMG_8456.PNG (1×750 px, 678 KB)

Event Timeline

Vibhabamba assigned this task to dr0ptp4kt.
Vibhabamba raised the priority of this task from to Needs Triage.
Vibhabamba updated the task description. (Show Details)

We already do this in Android (using a regex).

@Dbrant, I just verified this on Android and you are absolutely right. Removing Android App from this.
Thanks!

Let's fix this soon. :-)

Change 209163 had a related patch set uploaded (by Bgerstle):
do text sanitation on selected text before sharing

https://gerrit.wikimedia.org/r/209163

Change 209298 had a related patch set uploaded (by Bgerstle):
fix section share snippet XPath to only grab top-level <p>'s

https://gerrit.wikimedia.org/r/209298

Change 209163 merged by Mhurd:
do text sanitation on selected text before sharing

https://gerrit.wikimedia.org/r/209163

Change 209298 merged by Mhurd:
fix section share snippet XPath to only grab top-level <p>'s

https://gerrit.wikimedia.org/r/209298

@BGerstle - can you attach one more screenshot where the sentence has a reference superscript?
The first sentence in Madame Clinton's article has no superscripts.

Sorry to be a prude :(

@Vibhabamba sorry I posted that screenshot on the wrong ticket. You should be able to verify this and the other share a fact bug in today's alpha build (should be 107). Ping me when you get in if you need more info.

@BGerstle Ideally it doesn't matter what I select - I should not see numbers in the card.
It mostly works unless I really mess with it, which is possible for users.
Text selection is always jumpy, never accurate.

See if you can handle case 2 (Screenshot from the time article).
Just mess around with what you select in lead section.

@Bgerstle based on the other 3 screenshots, 99% of the times, i don't see superscripts.
This is signed off by design.

Re-checked the samples given by @Vibha - no superscripts are displayed in 4.3.1(109). However, I filed T98626
4.1.3(109) Cannot use a custom text selection in 'Share fact' - could be related to the fix?