Now Gather is being sunsetted this class is not being used by anything and should be removed from the repo.
- Mentioned In
- T98654: ios: Create overlay button doesn't capture clicks when keyboard open
T94764: Further tweaks to WikiGrok UI
rMEXT084fa87491af: Updated mediawiki/extensions Project: mediawiki/extensions/Gather…
rEGAT6be22f8a9a06: Use button with spinner for create collection button
T93424: More design tweaks to collections content overlay
- Mentioned Here
- T94233: [EPIC] Promote Gather to stable
T88559: VisualEditorOverlay should be written as an OO.ui.ProcessDialog
@bmansurov I think this totally the wrong way to do it. It makes it really difficult for us to move things to stable and it doesn't actually progress us in an way - we cannot load all our View code AND oojs ui it has to be one or the other.
As I've stated so many times T88559 is the best place to start this. The Overlay is our most complicated piece of code and VisualEditorOverlay is already using both libraries but not loading them all on startup and only for tablet. By rewriting this as a dialog we will be able to move to oojs ui fully effortlessly off the back of everything we discover.
Let's be honest moving to oojs ui is not a week worth of work, there's a hell of a lot we have to do before that.
The problem with introducing OO-UI widgets into MF code is that it is a complete anti-pattern to the existing framework.
MF's strongest pattern is the view/template/events map. Constructing widgets after these views are rendered goes entirely against that and makes our code look ugly. @kaldari, @Jdlrobson feel free to correct me / add ideas on what needs to happen to start introducing oo-ui widgets
This is still a valid bug @phuedx ButtonWithSpinner not being a View is a problem as it blocks T94233: Promote Gather to stable. We can work around the EventEmitter issues but the fact oojs ui is packaged up with all our other code is a problem we'll need to resolve.
We should rewrite the task to be clearer or create a new bug to that effect? What do you prefer?