Page MenuHomePhabricator
Create Task
Maniphest T95624

make buttons added by ContentTranslation to the top of Contributions behave like real links
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Currently the button elements that CX adds to the top of Special:Contributions are buttons, although in essence they change the URL.

Is there any reason not to convert them to real <a> links?

Details

SubjectRepoBranchLines +/-
Convert buttons on top of Special:Contribs to linksmediawiki/extensions/ContentTranslationmaster+16 -13
Customize query in gerrit

Related Objects

Event Timeline

Amire80 created this task.Apr 9 2015, 9:52 PM
Amire80 raised the priority of this task from to Medium.
Amire80 updated the task description. (Show Details)
Amire80 added projects: ContentTranslation, Design.
Amire80 added subscribers: Amire80, Pginer-WMF.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 9 2015, 9:52 PM
gerritbot subscribed.Apr 9 2015, 10:10 PM

Change 203234 had a related patch set uploaded (by Amire80):
Convert buttons on top of Special:Contribs to links

https://gerrit.wikimedia.org/r/203234

gerritbot added a project: Patch-For-Review.Apr 9 2015, 10:10 PM
gerritbot added a comment.Apr 10 2015, 3:28 AM

Change 203234 merged by jenkins-bot:
Convert buttons on top of Special:Contribs to links

https://gerrit.wikimedia.org/r/203234

Amire80 mentioned this in rMEXT0af6a93d5cfc: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Apr 10 2015, 3:29 AM
• santhosh mentioned this in rECTX97d9b8041df1: Convert buttons on top of Special:Contribs to links.Apr 10 2015, 3:29 AM
Nikerabbit subscribed.Apr 10 2015, 8:07 AM

Adding missing reference to earlier discussion: https://gerrit.wikimedia.org/r/#/c/200120/1/modules/entrypoint/ext.cx.contributions.js

Nikerabbit closed this task as Resolved.Apr 10 2015, 8:08 AM
Nikerabbit edited projects, added ContentTranslation-Release5, LE-Sprint-85; removed Patch-For-Review.
Nikerabbit set Security to None.
• santhosh moved this task from Backlog to Done on the LE-Sprint-85 board.Apr 10 2015, 10:52 AM
Arrbee assigned this task to Amire80.Apr 14 2015, 8:27 AM
Arrbee edited a custom field.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL