Page MenuHomePhabricator

Bug: Gather popup doesn't show all the content.
Closed, ResolvedPublic


I tried out Gather for the first time, and this is what the dialog looked like after I added the article to a collection.


  • View an article
  • Tap the star
  • Tap the input box for a new collection
  • The input box is no longer viewable.

Screenshot_2015-04-09-14-46-42.png (1×1 px, 271 KB)

Event Timeline

Ragesoss raised the priority of this task from to Needs Triage.
Ragesoss updated the task description. (Show Details)
Ragesoss added a project: Readers-Web-Backlog.
Ragesoss added subscribers: Ragesoss, Aklapper.
Moushira set Security to None.
Moushira added a subscriber: Moushira.

Okay, so now I see that the little modal is scrollable, but not big enough to show very much of the Gather interface at once. When I scroll the Gather modal, it also scrolls the content underneath (that is, the article title, photo and wikidata description).

IMG_0028.PNG (360×640 px, 118 KB)

Happened to me as well. While adding an article to an existing collection, the pop up freezes all of a sudden and doesn't scroll

cc/ @MSyed @JKatzWMF The current spacing and desing of the modal produces this results, it is not very friendly on small screens.

I would suggest changing the current spacing (1em left/right, 4em top/bottom) to be percent based, so that the spacing gets smaller as the screen gets smaller.

I've tried with 1% l/r and 3% t/d this are some screenshots:

Small viewport: (imagine the keyboard below)

Screen_Shot_2015-04-10_at_10.44.21_AM.png (292×540 px, 51 KB)

Full viewport:

Screen_Shot_2015-04-10_at_10.46.22_AM.png (828×556 px, 94 KB)

@JKatzWMF @Jhernandez We can try it. It might still look weird on smaller screens. But lets try it.

Jdlrobson renamed this task from Gather popup doesn't show all the content. to Bug: Gather popup doesn't show all the content..Apr 10 2015, 11:55 PM
Jdlrobson moved this task from Needs triage to In sprint on the Gather board.

I'll try a few styles and screenshot on different devices and post it here in the next sprint.

Some media queries would probably help here based on ios screen size.

Change 205834 had a related patch set uploaded (by Jhernandez):
Design: Improve spacing of content overlay on phones

See ⬆️ patch for review. Improved spacing on phones, see screenshots:

Screen_Shot_2015-04-22_at_1.22.34_PM.png (520×328 px, 35 KB)

Screen_Shot_2015-04-22_at_1.22.55_PM.png (256×328 px, 17 KB)

Much better that before, but still there is too much whitespace on the modal. See T96837 for further improvements

@joakino see my follow up commit and instructions to this:

Change 205834 merged by jenkins-bot:
Design: Improve spacing of content overlay on phones