Page MenuHomePhabricator
Create Task
Maniphest T95647

Merge CRM and DonationInterface queue wrappers
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

wmf_common/Queue.php should be based on PHPQueue, and could be merged with DonationQueue.

This is how we eventually get rid of ActiveMQ (SPOF)

Details

SubjectRepoBranchLines +/-
Update DonationInterface libwikimedia/fundraising/crmmaster+13 -12
Set source fields correctlywikimedia/fundraising/crmmaster+26 -29
Unify queue message handling with SmashPigmediawiki/extensions/DonationInterfacemaster+76 -359
Get rid of some more php-message-class, WmfFramework::getHostnamemediawiki/extensions/DonationInterfacemaster+9 -28
Consolidate queue message generation.mediawiki/extensions/DonationInterfacemaster+67 -149
Rename 'complete' queue to 'donations'mediawiki/extensions/DonationInterfacemaster+20 -19
Update SmashPig, use SourceFields logicmediawiki/extensions/DonationInterfacemaster+92 -75
Rename payments-init to payments-initialmediawiki/extensions/DonationInterfacemaster+8 -8
Allow overriding source name, type, and versionwikimedia/fundraising/SmashPigmaster+68 -14
Customize query in gerrit

Event Timeline

awight created this task.Apr 10 2015, 4:05 AM
awight raised the priority of this task from to Low.
awight updated the task description. (Show Details)
awight added projects: Fundraising-Backlog-Old, MediaWiki-extensions-DonationInterface, Wikimedia-Fundraising-CiviCRM, Technical-Debt.
awight subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 10 2015, 4:05 AM
awight raised the priority of this task from Low to Medium.Aug 10 2015, 7:20 PM
awight added a project: Fundraising-Backlog.
awight set Security to None.

Raising the priority cos this just became much more realistic. We should look at this during code freeze...

• DStrine updated the task description. (Show Details)Aug 11 2015, 9:18 PM
• DStrine moved this task from Triage to FY 2022-2023 on the Fundraising-Backlog board.
Danny_B moved this task from Unsorted to Combine / Incorporate on the Technical-Debt board.Jan 23 2016, 12:41 AM
• DStrine removed a project: Fundraising-Backlog-Old.Aug 5 2016, 8:41 PM
gerritbot subscribed.May 18 2017, 2:57 AM

Change 354177 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Allow overriding source name, type, and version

https://gerrit.wikimedia.org/r/354177

gerritbot added a project: Patch-For-Review.May 18 2017, 2:57 AM
gerritbot added a comment.May 19 2017, 4:43 PM

Change 354177 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Allow overriding source name, type, and version

https://gerrit.wikimedia.org/r/354177

gerritbot added a comment.May 19 2017, 6:59 PM

Change 354559 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Rename 'complete' queue to 'donations'

https://gerrit.wikimedia.org/r/354559

gerritbot added a comment.May 19 2017, 7:19 PM

Change 354566 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Update SmashPig, use SourceFields logic

https://gerrit.wikimedia.org/r/354566

gerritbot added a comment.May 19 2017, 10:37 PM

Change 354605 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] WIP consolidate queue message generation.

https://gerrit.wikimedia.org/r/354605

gerritbot added a comment.May 24 2017, 2:09 AM

Change 355370 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Get rid of some more php-message-class, WmfFramework::getHostname

https://gerrit.wikimedia.org/r/355370

gerritbot added a comment.May 30 2017, 10:42 PM

Change 355453 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] WIP Use QueueWrapper

https://gerrit.wikimedia.org/r/355453

gerritbot added a comment.May 30 2017, 10:46 PM

Change 356311 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Rename payments-init to payments-initial

https://gerrit.wikimedia.org/r/356311

gerritbot added a comment.May 30 2017, 11:34 PM

Change 356311 abandoned by Ejegg:
Rename payments-init to payments-initial

https://gerrit.wikimedia.org/r/356311

gerritbot added a comment.May 31 2017, 6:26 PM

Change 354559 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Rename 'complete' queue to 'donations'

https://gerrit.wikimedia.org/r/354559

gerritbot added a comment.May 31 2017, 6:28 PM

Change 354566 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Update SmashPig, use SourceFields logic

https://gerrit.wikimedia.org/r/354566

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)).May 31 2017, 7:00 PM
gerritbot added a comment.Jun 20 2017, 4:34 PM

Change 354605 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Consolidate queue message generation.

https://gerrit.wikimedia.org/r/354605

gerritbot added a comment.Jun 20 2017, 4:52 PM

Change 355370 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Get rid of some more php-message-class, WmfFramework::getHostname

https://gerrit.wikimedia.org/r/355370

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)); removed MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)).Jun 20 2017, 5:00 PM
• mmodell removed a subscriber: awight.Jun 22 2017, 9:33 PM
gerritbot added a comment.Jul 28 2017, 6:55 PM

Change 355453 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Unify queue message handling with SmashPig

https://gerrit.wikimedia.org/r/355453

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)); removed MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)).Jul 28 2017, 7:00 PM
Ejegg added a project: Fundraising Sprint Navel Warfare.Jul 28 2017, 7:09 PM
Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint Navel Warfare board.
Ejegg moved this task from FY 2022-2023 to Current Sprint and Completed in Q1 2017-18 on the Fundraising-Backlog board.Jul 28 2017, 7:37 PM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Navel Warfare board.Jul 31 2017, 7:55 PM
gerritbot added a comment.Jul 31 2017, 8:04 PM

Change 368848 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Update DonationInterface lib

https://gerrit.wikimedia.org/r/368848

Ejegg moved this task from Done to Doing on the Fundraising Sprint Navel Warfare board.Aug 1 2017, 5:02 PM
• DStrine added a project: Fundraising Sprint Outie Inverter.Aug 2 2017, 8:20 PM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Outie Inverter board.Aug 3 2017, 7:18 PM
gerritbot added a comment.Aug 4 2017, 10:20 PM

Change 370289 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Set source fields correctly

https://gerrit.wikimedia.org/r/370289

gerritbot added a comment.Aug 7 2017, 2:38 PM

Change 370289 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Set source fields correctly

https://gerrit.wikimedia.org/r/370289

• DStrine added a project: Fundraising Sprint Prank Seatbelt.Aug 16 2017, 8:30 PM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Prank Seatbelt board.Aug 22 2017, 4:51 PM
gerritbot added a comment.Aug 24 2017, 10:24 PM

Change 368848 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Update DonationInterface lib

https://gerrit.wikimedia.org/r/368848

Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Prank Seatbelt board.Aug 25 2017, 6:05 PM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Prank Seatbelt board.Aug 28 2017, 7:34 PM
Ejegg closed this task as Resolved.Aug 29 2017, 8:06 PM
Ejegg claimed this task.
Ejegg set the point value for this task to 4.
Ejegg changed the point value for this task from 4 to 8.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL