Page MenuHomePhabricator
Create Task
Maniphest T95708

<span lang="XX-YY"> added on XX Wikipedia
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

In https://fr.wikipedia.org/w/index.php?diff=113669090 there were many <span lang="fr-FR"> tags added, even though it's on the French Wikipedia. This looks like T71494 but I'm not sure it's exactly the same issue. One cause might be the mix of French and English text.

See also https://en.wikipedia.org/w/index.php?diff=656444224 with <span lang="EN-US"> on the English Wikipedia.

Details

SubjectRepoBranchLines +/-
Strip language annotations on external importmediawiki/extensions/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

gpaumier created this task.Apr 10 2015, 3:50 PM
gpaumier raised the priority of this task from to Needs Triage.
gpaumier updated the task description. (Show Details)
gpaumier added projects: VisualEditor, VisualEditor 2014/15 Q4 blockers.
gpaumier subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 10 2015, 3:50 PM
gpaumier mentioned this in T71494: Insufficient span tags stripping from copy-and-paste in Safari.Apr 10 2015, 3:50 PM
Jdforrester-WMF assigned this task to Esanders.Apr 10 2015, 5:21 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF added a project: VisualEditor-DataModel.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Nnemo subscribed.Apr 12 2015, 9:26 PM
gpaumier renamed this task from <span lang="fr-FR"> added on the French Wikipedia to <span lang="XX-YY"> added on XX Wikipedia.Apr 14 2015, 3:55 PM
gpaumier updated the task description. (Show Details)
gpaumier mentioned this in T94767: Perform a weekly review of edits made with VisualEditor.Apr 14 2015, 5:35 PM
• Whatamidoing-WMF mentioned this in T96101: <span lang="XX-YY"> added on ZZ Wikipedia .Apr 14 2015, 11:08 PM
Liuxinyu970226 subscribed.Apr 15 2015, 3:13 AM
Jdforrester-WMF moved this task from To Triage to External and Administrivia on the VisualEditor board.Apr 16 2015, 9:25 PM
matmarex added subscribers: matmarex, NicoV.Apr 21 2015, 11:54 AM

Variants with just <span lang="XX">:

https://fr.wikipedia.org/w/index.php?title=Chip-Seq&oldid=113950851
<span lang="FR">Séquençage simple-molécule</span>

https://fr.wikipedia.org/w/index.php?title=Liberlande&diff=prev&oldid=113947611
<span lang="fr">Citoyenneté</span>

matmarex mentioned this in T96589: More <span> corruption (unknown source).Apr 21 2015, 12:07 PM
gerritbot subscribed.Apr 21 2015, 12:25 PM

Change 205585 had a related patch set uploaded (by Esanders):
Strip language annotations on external import

https://gerrit.wikimedia.org/r/205585

gerritbot added a project: Patch-For-Review.Apr 21 2015, 12:25 PM
Esanders added a comment.Apr 21 2015, 12:25 PM

Couldn't reproduce this locally, but will add language annotations to the external import blacklist, which should prevent this.

Esanders merged a task: T96101: <span lang="XX-YY"> added on ZZ Wikipedia .Apr 21 2015, 12:45 PM
Esanders added a subscriber: • Whatamidoing-WMF.
• Elitre subscribed.Apr 21 2015, 1:28 PM
gerritbot added a comment.Apr 22 2015, 12:33 AM

Change 205585 merged by jenkins-bot:
Strip language annotations on external import

https://gerrit.wikimedia.org/r/205585

Jdforrester-WMF mentioned this in rEVEDe229e73fc665: Strip language annotations on external import.Apr 22 2015, 12:33 AM
Jay8g subscribed.Apr 22 2015, 2:57 AM
Jdforrester-WMF moved this task from Nominated to Backlog: Urgent Fixes on the VisualEditor 2014/15 Q4 blockers board.Apr 22 2015, 6:26 PM
matmarex merged a task: T97122: VisualEditor should stop adding <span lang="pt"> tags.Apr 24 2015, 4:47 PM
matmarex added a subscriber: He7d3r.
Jdforrester-WMF closed this task as Resolved.Apr 24 2015, 4:47 PM
Jdforrester-WMF edited projects, added WMF-deploy-2015-04-22_(1.26wmf3); removed Patch-For-Review.
Jdforrester-WMF moved this task from Backlog: Urgent Fixes to Done on the VisualEditor 2014/15 Q4 blockers board.
Jdforrester-WMF removed a subscriber: He7d3r.
Liuxinyu970226 unsubscribed.Apr 25 2015, 12:22 AM
Jdforrester-WMF moved this task from External and Administrivia to FY 18-19 Q3/Q4 on the VisualEditor board.May 6 2015, 12:56 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL