API: Inconsistent response for empty collections
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Apr 10 2015, 6:52 PM

Description

Make this query (or similar):
http://localhost:8888/w/api.php?action=query&format=json&prop=pageimages&piprop=thumbnail&pithumbsize=150&pilimit=50&generator=listpages&glspid=70&glsplimit=50

When collection with id 150 is empty I get a [] in my response
When it's not I get
{"query":{"pages":{"6":{"pageid":6,"ns":0,"title":"Albert Einstein","thumbnail":{"source":"http://localhost:8888/w/images/thumb/3/3e/Einstein_1921_by_F_Schmutzer_-_restoration.jpg/91px-Einstein_1921_by_F_Schmutzer_-_restoration.jpg","width":91,"height":120}}}}}

Please be consistent and always return an array or an object.

Related Objects
Search...

Status	Assigned	Task
Resolved	Jdlrobson	T95741 API: Inconsistent response for empty collections
Resolved	Anomie	T12887 API JSON formatter returns [] as an empty return value - inconsistent with {} for non-empty values
Resolved	Anomie	T76728 Clean up ApiResult and ApiFormatXml, create new formatversion
Resolved	Anomie	T85236 Better unit testing for ApiFormat*
Resolved	EBernhardson	T90745 Flow ApiFlowModerateTopicTest::testModerateTopic() assumes ApiResult will pass through arbitrary objects
Resolved	Anomie	T98083 add checkbox to ApiSandbox to use formatversion=2
Resolved	Anomie	T98086 improve RELEASE-NOTES-1.25 for formatversion=2 change
Open	None	T212069 API action=wbgetentities does not handle formatversion=2

Event Timeline

Jdlrobson created this task.Apr 10 2015, 6:52 PM

Jdlrobson assigned this task to Yurik.

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Gather Sprint Enwiki.

Jdlrobson moved this task to In Analysis on the Gather Sprint Enwiki board.

Jdlrobson added a subscriber: Jdlrobson.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 10 2015, 6:52 PM

Yurik added a subtask: T12887: API JSON formatter returns [] as an empty return value - inconsistent with {} for non-empty values.Apr 10 2015, 6:58 PM

Jdlrobson edited projects, added Gather; removed Gather Sprint Enwiki.Apr 11 2015, 12:46 AM

Jdlrobson set Security to None.

• Moushira added a subscriber: • Moushira.Apr 13 2015, 8:07 AM

Jdlrobson moved this task from Needs triage to This Sprint on the Gather board.Apr 16 2015, 5:40 PM

Jdlrobson renamed this task from API: Inconsistnet response for empty collections to API: Inconsistent response for empty collections.Apr 16 2015, 5:45 PM

Jdlrobson removed Yurik as the assignee of this task.

Jdlrobson added a project: Gather Sprint Greatest Hits.

Jdlrobson edited a custom field.

Anomie closed subtask T12887: API JSON formatter returns [] as an empty return value - inconsistent with {} for non-empty values as Resolved.Apr 21 2015, 2:00 PM