- The chrome status bar should be hidden whilst the editor overlay is open
- When user is on collection edit screen, there is a back button instead of an X in the top-left corner
- Change label of 'Done' to 'Save' (T97266)
- When you add / remove items to the collection, these do not get saved instantly and no toast is shown. Clicking 'Done' will cause the removal/addition of new items to the collection.
- When clicking done and the changes have been saved the page gets refreshed to show you the new members in the collection. A toast is shown after the page has been reloaded to tell you that the changes occured.
- When you click back button and you have staged changes you get a prompt asking you to confirm that you will lose changes.
- Change the text of the edit button to 'Edit name and description' in the overlay
- When you click 'edit name and description' on the screen with the title and description the button in the top right corner says 'Done' and is green and clicking it takes you back to the interface for adding and removing items
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Jdlrobson | T95776 Edit collection overlay changes | |||
| Declined | Jdlrobson | T96297 Hide chrome status bar when overlays are open | |||
| Resolved | • Jhernandez | T97266 for edit overlay, change label of done to save |
Event Timeline
Comment Actions
Change 204635 had a related patch set uploaded (by Jdlrobson):
Swap X button for arrow for editor overlay
Comment Actions
Change 204642 had a related patch set uploaded (by Jdlrobson):
Make edits to title and description instanenous
Comment Actions
Change 204643 had a related patch set uploaded (by Jdlrobson):
Change button label for edit button in edit collection overlay
Comment Actions
Change 204659 had a related patch set uploaded (by Jdlrobson):
Save changes to members of collection only when done clicked
Comment Actions
Change 204643 merged by jenkins-bot:
Change button label for edit button in edit collection overlay
Comment Actions
This is the only one remaining to be reviewed. I don't understand why the editing of title/description is now instant but the adding/removing of items is going to be delayed until clicking done. Also it seems dangerous to have all that state pending until the user clicks done. I personally like how it is now, I don't have to worry that my list of 50 new elements will be lost if anything happens and I don't click Done (browser crashes, I loose connection, etc).
Comment Actions
cc/ @Jdlrobson @JKatzWMF ^
Just to spark some conversation. I'll review the patch in a bit.
Comment Actions
Hi Joaquin-I agree that it is a little suboptimal. Though I am starting to see instant saves on mobile devices, I think people are still used to the ability to back out of a save. it is still the dominant paradigm and the most accesible, comprehensible one for the greatest majority...which is our audience.
I would rather clear up the inconsistency by changing it so the edit/description not saved until you hit the save button on the next page...but in the near term, we should move the name and desc to the main edit page.
Comment Actions
@Jdlrobson Plz review PS3, I've changed how we make the ajax call so that they are parallel and only happen if they actually need to (the add call was always happening if there were removed items). Ping me back to merge this or merge yourself if that change seems good! 👍 🍻
Comment Actions
Change 204659 merged by jenkins-bot:
Save changes to members of collection only when done clicked
Comment Actions
"Done" button on edit overlay still says done
can't verify on mobile phone--server seems down