Right after a page is loaded, the editnotice dial displays as empty.
Affects at least dewiki, itwiki, plwiki, ptwiki and ruwiki.
See also:
tarlocesilion | |
Apr 11 2015, 10:52 PM |
F158888: 1Снимок.PNG | |
Apr 30 2015, 7:36 PM |
F116838: Indh0tP.png | |
Apr 18 2015, 9:22 PM |
F111639: empty_pl.png | |
Apr 11 2015, 10:52 PM |
F111638: empty_it.png | |
Apr 11 2015, 10:52 PM |
Right after a page is loaded, the editnotice dial displays as empty.
Affects at least dewiki, itwiki, plwiki, ptwiki and ruwiki.
See also:
pl.wp and it.wp seem to be using the same system as en.wp had previously; de.wp has something similar, but slightly different. en.wp's implementation was modified per T91715 to avoid this issue.
Please stop expanding the scope of this task. The task is to help five specific wikis.
I'm increasingly convinced that we should go back to handling this correctly in the software.
We already changed the software to support the concept of inherited edit notices (e.g. "MediaWiki:Editnotice-0") while retaining the ability for that inherited template to conditionally load an actual edit notice.
Edit notice "existence" used to be derived on the page having no wikitext (which necessitated VisualEditor to do visual text extraction).
MediaWiki core now parses the edit notice and if no HTML was produced by the wikitext, the edit notice is not exported. The client-side performance benefit is substantial in the VE loading process. The added server-side processing is not a concern.
This system is the best of both, but does require a small sacrifice from both parties. The software now does additional parsing and extraction. But the template is now required to not output any boilerplate that wouldn't be visible anyway.
Essentially the fix is to either remove the unnecessarily html, or move it to be part of the conditional logic.
Simple cases:
Advanced case of en.wikipedia.org is documented at https://phabricator.wikimedia.org/T91715#1160062.
+ I see it on Meta.wikimedia.org https://meta.wikimedia.org/wiki/VisualEditor/Newsletter?veaction=edit
I still see this on ptwiki, because I use CSS like this to hide the notices:
[id*="editnotice-"]{ display: none !important; }
Yeah. That is, unfortunately, explicitly not supported since T87412 (and that's the entire reason for this bug).