The yamllint job is based on the python implementation which is not always suitable since some repositories are using a PHP or JavaScript implementation. It is also causing us to have to maintain per repo specific jobs.
Instead, the yaml linting should be done by a test embedded in the repository and run by the usual test job (npm test, tox, etc).
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | hashar | T95890 Phase out yamllint jobs | |||
| Declined | Amire80 | T95892 Add a PHP test to lint ContentTranslation yaml files | |||
| Resolved | bd808 | T95894 Status of Jouncebot and dropping the yamllint Jenkins job | |||
| Resolved | hashar | T96014 Remove tools/yamllint.py from integration/jenkins once yamllint jobs disappear | |||
| Resolved | polybuildr | T95891 Add npm test command to grrrit and have it to lint js/yaml files | |||
| Resolved | hashar | T114470 Add YAML lint test in wikimedia/fundraising/tools to remove the Jenkins job 'yamllint' |
Change 242126 had a related patch set uploaded (by Hashar):
Tweak 'yamlllint' Gerrit message to mention deprecation
Change 242126 merged by jenkins-bot:
Tweak 'yamlllint' Gerrit message to mention deprecation
Job is gone from Jenkins and I have deleted the workspace. The script is gone as well.
Remaining 'blockers' are todo tasks to have the repo use tests instead. Some even have patches associated.
[12:53] <aharoni> hashar: https://phabricator.wikimedia.org/T95892
[12:53] <aharoni> is there anything left to do?
[12:54] <aharoni> Is ContentTranslation still different from other extensions in any regard? It should be the same.
[12:55] <+hashar> aharoni: do you have a PHPUnit test that lint the YAML files ?
[12:55] <aharoni> I don't think so. Where do I add it?
[12:55] <aharoni> How is it done in other extensions?
[12:56] <aharoni> It's .rubocop.yml, so it should be the same as all the other extensions that have .rubocop.yml.