Page MenuHomePhabricator
Create Task
Maniphest T95891

Add npm test command to grrrit and have it to lint js/yaml files
Closed, ResolvedPublic
Actions

Description

The labs/tools/grrrit has three Jenkins jobs defined: jshint , jsonlint and yamllint. I would like to migrate to have jenkins simply run npm test to reduce the number of jobs we have to maintained and let the grrrit developers easily define tests they need.

Moreover, the yamllint job in Jenkins is using the python implementation whereas grrrit is using node.js.

Please see https://www.mediawiki.org/wiki/Continuous_integration/Entry_points#JavaScript for help defining the npm entry point. Once done, we can switch CI to use it instead of the custom jobs.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Remove jshint and jsonlint jobs from labs/tools/grrritPolybuildrintegration/configmaster+0 -9
Add Grunt to run JSHintPolybuildrlabs/tools/grrritmaster+21 -2
Use `npm test` to lint YAMLPolybuildrlabs/tools/grrritmaster+2 -1
[grrrit] Trigger npm for grrritHasharintegration/configmaster+6 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.Apr 13 2015, 2:27 PM
hashar raised the priority of this task from to Needs Triage.
hashar updated the task description. (Show Details)
hashar added a project: grrrit-wm.
hashar subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 13 2015, 2:27 PM
hashar added a parent task: T95890: Phase out yamllint jobs.Apr 13 2015, 2:28 PM
hashar added a subscriber: grrrit-wm.Jul 29 2015, 7:56 AM

Poking grrrit-wm members :-)

hashar added a comment.Sep 27 2015, 12:37 PM

grrrit folks any clue how to write a npm based test that lints the yaml files in Grrrit? I would like to phase out the python based Jenkins job 'yamllint'.

polybuildr subscribed.Sep 27 2015, 12:44 PM

You're looking for some configuration of npm modules such that when you run npm test, the YAML files get linted?

polybuildr added a comment.Sep 27 2015, 12:54 PM

If that's what you're looking for, js-yaml is a very easy-to-use node module. Running js-yaml file.yaml prints out the JSON for the YAML in the file and the return status code of js-yaml tells us whether there was an error or not. Errors get logged to console too, of course.

If we don't want to run the js-yaml module directly, we can use grunt-yamllint as a grunt task.

gerritbot subscribed.Sep 27 2015, 1:25 PM

Change 241523 had a related patch set uploaded (by Polybuildr):
Use npm test to lint YAML

https://gerrit.wikimedia.org/r/241523

gerritbot added a project: Patch-For-Review.Sep 27 2015, 1:25 PM
polybuildr added a comment.Sep 27 2015, 1:30 PM

The project was already using js-yaml as a dependency, so I gave this a shot by putting in a js-yaml config.yaml as the npm test script.

hashar added a comment.Sep 27 2015, 1:54 PM

Whatever works :-} Seems using the already provided js-yaml will do. Thank you!

gerritbot added a comment.Sep 28 2015, 10:00 AM

Change 241615 had a related patch set uploaded (by Hashar):
[grrrit] Trigger npm for grrrit

https://gerrit.wikimedia.org/r/241615

gerritbot added a comment.Sep 28 2015, 11:35 AM

Change 241615 merged by jenkins-bot:
[grrrit] Trigger npm for grrrit

https://gerrit.wikimedia.org/r/241615

hashar mentioned this in rCICFcbdd0a5f8979: [grrrit] Trigger npm for grrrit.Sep 28 2015, 11:35 AM
gerritbot added a comment.Sep 28 2015, 11:36 AM

Change 241523 merged by jenkins-bot:
Use npm test to lint YAML

https://gerrit.wikimedia.org/r/241523

polybuildr mentioned this in rTGRT282bb0c346d8: Use `npm test` to lint YAML.Sep 28 2015, 11:38 AM
hashar updated the task description. (Show Details)Sep 28 2015, 11:46 AM
hashar set Security to None.

yaml is done thanks. jsonlint/jshint should be done with Grunt probably.

hashar removed a parent task: T95890: Phase out yamllint jobs.Sep 28 2015, 11:47 AM
hashar removed a project: Patch-For-Review.
polybuildr added a comment.Sep 28 2015, 7:50 PM

Doing jsonlint using Grunt is a little weird, actually. The only JSON file that I can see in the repo is the package.json file. In order to use npm test, which will then get Grunt to lint the package.json file, the package.json file has to be valid in the first place. :P

I'll submit a patch soon that does the JSHinting using Grunt, but we probably need to rethink jsonlint.

gerritbot added a comment.Sep 28 2015, 8:05 PM

Change 241754 had a related patch set uploaded (by Polybuildr):
Add Grunt to run JSHint

https://gerrit.wikimedia.org/r/241754

gerritbot added a project: Patch-For-Review.Sep 28 2015, 8:05 PM
hashar assigned this task to polybuildr.Sep 28 2015, 8:05 PM

Indeed, no need to add jsonlint. I am happy to see you are working on adding jshint \O/

gerritbot added a comment.Sep 28 2015, 8:07 PM

Change 241754 merged by jenkins-bot:
Add Grunt to run JSHint

https://gerrit.wikimedia.org/r/241754

polybuildr mentioned this in rTGRTb448b0ebbe26: Add Grunt to run JSHint.Sep 28 2015, 8:07 PM
gerritbot added a comment.Sep 28 2015, 8:13 PM

Change 241757 had a related patch set uploaded (by Polybuildr):
Remove jshint and jsonlint jobs from labs/tools/grrrit

https://gerrit.wikimedia.org/r/241757

gerritbot added a comment.Sep 28 2015, 8:44 PM

Change 241757 merged by jenkins-bot:
Remove jshint and jsonlint jobs from labs/tools/grrrit

https://gerrit.wikimedia.org/r/241757

polybuildr mentioned this in rCICF5faf2e32d5c1: Remove jshint and jsonlint jobs from labs/tools/grrrit.Sep 28 2015, 8:44 PM
hashar closed this task as Resolved.Sep 28 2015, 8:47 PM

Aced by @polybuildr !

hashar added a parent task: T95890: Phase out yamllint jobs.Sep 29 2015, 1:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits