Page MenuHomePhabricator
Create Task
Maniphest T95898

bad curl causes citoid to respond with a traceback
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

curl -d '{"url":"http://www.lemonde.fr/politiq"format":"badformat"}' --header "Content-Type: application/json" localhost:1970/url
TypeError: Cannot call method &#39;log&#39; of undefined<br> &nbsp; &nbsp;at /home/marielle/Code/Node/citoid/lib/util.js:193:14<br> &nbsp; &nbsp;at Layer.handle_error (/home/marielle/Code/Node/citoid/node_modules/express/lib/router/layer.js:58:5)<br> &nbsp; &nbsp;at trim_prefix (/home/marielle/Code/Node/citoid/node_modules/express/lib/router/index.js:300:13)<br> &nbsp; &nbsp;at /home/marielle/Code/Node/citoid/node_modules/express/lib/router/index.js:270:7<br> &nbsp; &nbsp;at Function.proto.process_params (/home/marielle/Code/Node/citoid/node_modules/express/lib/router/index.js:321:12)<br> &nbsp; &nbsp;at next (/home/marielle/Code/Node/citoid/node_modules/express/lib/router/index.js:261:10)<br> &nbsp; &nbsp;at Layer.handle_error (/home/marielle/Code/Node/citoid/node_modules/express/lib/router/layer.js:54:12)<br> &nbsp; &nbsp;at trim_prefix (/home/marielle/Code/Node/citoid/node_modules/express/lib/router/index.js:300:13)<br> &nbsp; &nbsp;at /home/marielle/Code/Node/citoid/node_modules/express/lib/router/index.js:270:7<br> &nbsp; &nbsp;at Function.proto.process_params (/home/marielle/Code/Node/citoid/node_modules/express/lib/router/index.js:321:12)<br> &nbsp; &nbsp;at next (/home/marielle/Code/Node/citoid/node_modules/express/lib/router/index.js:261:10)<br> &nbsp; &nbsp;at Layer.handle_error (/home/marielle/Code/Node/citoid/node_modules/express/lib/router/layer.js:54:12)<br> &nbsp; &nbsp;at trim_prefix (/home/marielle/Code/Node/citoid/node_modules/express/lib/router/index.js:300:13)<br> &nbsp; &nbsp;at /home/marielle/Code/Node/citoid/node_modules/express/lib/router/index.js:270:7<br> &nbsp; &nbsp;at Function.proto.process_params (/home/marielle/Code/Node/citoid/node_modules/express/lib/router/index.js:321:12)<br> &nbsp; &nbsp;at next (/home/marielle/Code/Node/citoid/node_modules/express/lib/router/index.js:261:10)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Update citoid to 7e3ee47Mobrovacmediawiki/services/citoid/deploymaster+12 K -302 K
Customize query in gerrit

Related Objects
Search...

Event Timeline

Mvolz created this task.Apr 13 2015, 3:19 PM
Mvolz raised the priority of this task from to Needs Triage.
Mvolz updated the task description. (Show Details)
Mvolz added projects: Citoid, Services.
Mvolz moved this task to Service on the Citoid board.
Mvolz added subscribers: Mvolz, • mobrovac.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 13 2015, 3:19 PM
Mvolz triaged this task as Medium priority.Apr 13 2015, 3:27 PM
Mvolz updated the task description. (Show Details)
Mvolz set Security to None.
• mobrovac added a subtask: T96009: bodyParser causes template's overridden handlers not to work.Apr 14 2015, 10:24 AM

This is a consequence of T96009 and happens only for POST requests.

• mobrovac closed subtask T96009: bodyParser causes template's overridden handlers not to work as Invalid.Apr 14 2015, 10:47 AM
• mobrovac added a comment.Apr 14 2015, 10:50 AM
In T95898#1206128, @mobrovac wrote:

This is a consequence of T96009 and happens only for POST requests.

Strike that, in the template works as expected. It still happens only for POST requests, while GET requests kill Citoid. We will need to investigate this a bit thoroughly. One possible cause is that async and promises do not mix well. That would explain the crash for GET requests, but probably not for POSTs...

• mobrovac claimed this task.Apr 21 2015, 1:31 PM
• mobrovac added a comment.Apr 21 2015, 7:00 PM

https://gerrit.wikimedia.org/r/#/c/205645/ fixes the issue.

• mobrovac moved this task from Service to Backlog on the Citoid board.Apr 21 2015, 7:01 PM
• mobrovac moved this task from Backlog to Waiting on Deploy on the Citoid board.
gerritbot subscribed.Apr 22 2015, 3:45 PM

Change 205872 had a related patch set uploaded (by Mobrovac):
Update citoid to 7e3ee47

https://gerrit.wikimedia.org/r/205872

gerritbot added a project: Patch-For-Review.Apr 22 2015, 3:45 PM
gerritbot added a comment.Apr 22 2015, 4:46 PM

Change 205872 merged by Mobrovac:
Update citoid to 7e3ee47

https://gerrit.wikimedia.org/r/205872

Jdforrester-WMF closed this task as Resolved.Apr 22 2015, 4:59 PM
Jdforrester-WMF edited projects, added: WMF-deploy-2015-04-22_(1.26wmf3), VisualEditor 2014/15 Q4 blockers; removed: Patch-For-Review.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q4 blockers board.
• mobrovac mentioned this in rGCIDa343b09282ce: Update citoid to 7e3ee47.Apr 22 2015, 5:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits