Page MenuHomePhabricator
Create Task
Maniphest T95909

IE8 shows "are you sure you want to leave" even when NOT in edit more
Closed, ResolvedPublic
Actions

Description

Seen in IE8 only

Steps:

  • go to a flow board
  • refresh the page

Actual:

  • shows a popup asking to confirm to leave the page

Expected:

  • nothing, since not in edit mode

Workaround:

  • go to edit mode (i.e. reply to a topic) and cancel to force it to not be in edit mode

Details

SubjectRepoBranchLines +/-
Don't ask for confirmation to leave the page when there is no unsaved modifications.mediawiki/extensions/Flowmaster+8 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

SBisson created this task.Apr 13 2015, 4:11 PM
SBisson raised the priority of this task from to Needs Triage.
SBisson updated the task description. (Show Details)
SBisson added projects: Collaboration-Team-Triage, StructuredDiscussions.
SBisson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 13 2015, 4:11 PM
• Mattflaschen-WMF added a parent task: T87121: IE 8 support - Flow issues (tracking).Apr 13 2015, 4:13 PM
EBernhardson triaged this task as Medium priority.Apr 13 2015, 5:51 PM
EBernhardson subscribed.
gerritbot subscribed.Apr 14 2015, 2:25 PM

Change 204056 had a related patch set uploaded (by Sbisson):
Don't ask for confirmation to leave the page when there is no unsaved modifications.

https://gerrit.wikimedia.org/r/204056

gerritbot added a project: Patch-For-Review.Apr 14 2015, 2:25 PM
SBisson claimed this task.Apr 14 2015, 2:26 PM
SBisson added a project: Collaboration-Team-Sprint-U-2015-04-22.
SBisson set Security to None.
SBisson moved this task from Sprint U - ends April 22 to Needs Review on the Collaboration-Team-Sprint-U-2015-04-22 board.
SBisson added a comment.Apr 14 2015, 2:29 PM

I know this was not a high priority but it was so annoying that I had to fix it during my testing. And since it's fixed, might as well go all the way and patch it.

gerritbot added a comment.Apr 14 2015, 2:45 PM

Change 204056 merged by jenkins-bot:
Don't ask for confirmation to leave the page when there is no unsaved modifications.

https://gerrit.wikimedia.org/r/204056

SBisson mentioned this in rEFLWf5adf4d65572: Don't ask for confirmation to leave the page when there is no unsaved….Apr 14 2015, 2:45 PM
Diffusion mentioned this in rMEXT4b87f3087038: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Apr 14 2015, 2:46 PM
SBisson moved this task from Needs Review to Product Review on the Collaboration-Team-Sprint-U-2015-04-22 board.Apr 14 2015, 3:13 PM
• DannyH subscribed.Apr 14 2015, 9:02 PM

I don't know how to product review this... who's got IE8? :)

EBernhardson added a comment.Apr 14 2015, 9:03 PM

two options:

A) sauce labs

B) http://www.modern.ie/en-us/virtualization-tools#downloads

• Mattflaschen-WMF subscribed.Apr 14 2015, 9:05 PM

You should be able to get access to Sauce Labs through Wikimedia.

• DannyH closed this task as Resolved.Apr 16 2015, 9:17 PM

Works on Beta/Sauce Labs

SBisson moved this task from Product Review to Done on the Collaboration-Team-Sprint-U-2015-04-22 board.Apr 17 2015, 4:39 PM
• DannyH moved this task from Untriaged to Resolved on the Collaboration-Team-Triage board.Apr 17 2015, 9:25 PM
Quiddity mentioned this in T72586: Flow: user always getting "are you sure you want to leave this page?" pop-up when exiting a flow page.Apr 18 2015, 9:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL