action.abort.type in Schema:Edit not populated for Wikitext
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Halfak
	Apr 13 2015, 7:37 PM

Description

It looks like the action.abort.type field is not populated for Wikitext. Having this field will be critical for comparing usage patterns of Wikitext to VE.

> SELECT DISTINCT event_editor, `event_action.abort.type` FROM Edit_11448630 WHERE timestamp BETWEEN "20150401" AND "20150402";
+--------------+-------------------------+
| event_editor | event_action.abort.type |
+--------------+-------------------------+
| wikitext     | NULL                    |
| visualeditor | nochange                |
| visualeditor | abandon                 |
| visualeditor | NULL                    |
| visualeditor | switchwithout           |
| visualeditor | preinit                 |
| visualeditor | switchwith              |
| visualeditor | abandonMidsave          |
+--------------+-------------------------+
8 rows in set (1 min 1.64 sec)

Details

Subject	Repo	Branch	Lines +/-
Populate abort.type in Schema:Edit logging	mediawiki/extensions/WikiEditor	wmf/1.26wmf3	+14 -4
Populate abort.type in Schema:Edit logging	mediawiki/extensions/WikiEditor	wmf/1.26wmf4	+14 -4
Populate abort.type in Schema:Edit logging	mediawiki/extensions/WikiEditor	master	+14 -4

Customize query in gerrit

Related Objects

Mentioned In: rEWED814f5678b624: Populate abort.type in Schema:Edit logging
rEWED006e9d64e4d0: Populate abort.type in Schema:Edit logging
rEWEDd1270ed4b65e: Populate abort.type in Schema:Edit logging
rMEXT71dfd477bdaf: Updated mediawiki/extensions Project: mediawiki/extensions/WikiEditor…

Event Timeline

Halfak created this task.Apr 13 2015, 7:37 PM

Halfak raised the priority of this task from to Needs Triage.

Halfak updated the task description. (Show Details)

Halfak added a project: VisualEditor.

Halfak subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 13 2015, 7:37 PM

Halfak updated the task description. (Show Details)Apr 13 2015, 7:38 PM

Halfak set Security to None.

Krenair edited projects, added WikiEditor; removed VisualEditor.Apr 13 2015, 8:19 PM

I was under the impression that we wouldn't need abort.type immediately? That property is flawed anyway.

I will need it to compare edit completion rates. It seems that excluding "nochange" aborts will be critical for fairly comparing Wikitext and VE.

The "nochange" part is the problem really. It is not a type of abort, it is the state of the editor at the time of the abort. (a successful save is sometimes a nochange, though we don't log it as an abort) Otherwise you'd need to be able to combine it with the other types.

It seems like one could record an event in javascript on key press of the text area that would set a "changed" boolean.

I just realized that "Ctrl-C" would need to be excluded as that would be a common operation yielding "nochange".

Jdforrester-WMF triaged this task as Medium priority.Apr 15 2015, 12:07 AM

Jdforrester-WMF added a project: VisualEditor 2014/15 Q4 blockers.

Catrope renamed this task from action.abort.type in Shema:Edit not populated for Wikitext to action.abort.type in Schema:Edit not populated for Wikitext.Apr 15 2015, 12:17 AM

• Rdicerb subscribed.Apr 15 2015, 12:53 AM

• Elitre subscribed.Apr 15 2015, 10:27 AM

Change 205195 had a related patch set uploaded (by Catrope):
Populate abort.type in Schema:Edit logging

https://gerrit.wikimedia.org/r/205195

gerritbot added a project: Patch-For-Review.Apr 20 2015, 1:15 AM

Krenair assigned this task to Catrope.Apr 20 2015, 3:13 AM

Jdforrester-WMF moved this task from Nominated to Backlog: Urgent Fixes on the VisualEditor 2014/15 Q4 blockers board.Apr 29 2015, 6:22 PM

Jdforrester-WMF edited a custom field.Apr 29 2015, 6:51 PM

Jdforrester-WMF moved this task from Backlog: Urgent Fixes to Doing on the VisualEditor 2014/15 Q4 blockers board.May 1 2015, 12:50 AM

Change 205195 merged by jenkins-bot:
Populate abort.type in Schema:Edit logging

https://gerrit.wikimedia.org/r/205195

Diffusion mentioned this in rMEXT71dfd477bdaf: Updated mediawiki/extensions Project: mediawiki/extensions/WikiEditor….May 5 2015, 1:19 AM