Page MenuHomePhabricator
Create Task
Maniphest T95966

When search returns no results no behaviour defined.
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

If I go to a collection, and click edit and search for new members
e.g.
http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather/by/Jdlrobson/5#/collection/edit/5
when i type goobledegook the search returns no results but the UI does not reflect this.

This could be a solution right now.

SeachisSad.png (1×748 px, 38 KB)

Try another search is a button which when clicked clears input.

Our empty screens for all search pages (desktop and mobile) are pretty awful. Maybe the Search team will take a look at fixing that in the future :)

Details

SubjectRepoBranchLines +/-
Display a message for no search resultsmediawiki/extensions/Gathermaster+40 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Apr 13 2015, 10:37 PM
Jdlrobson claimed this task.
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: Gather, Gather Sprint Forward.
Jdlrobson added subscribers: Aklapper, Jdlrobson, • MSyed.
Jdlrobson reassigned this task from Jdlrobson to • MSyed.Apr 16 2015, 4:45 PM
Jdlrobson set Security to None.
Jdlrobson moved this task from Needs triage to This Sprint on the Gather board.Apr 16 2015, 5:39 PM
Jdlrobson updated the task description. (Show Details)Apr 16 2015, 5:44 PM
Jdlrobson edited a custom field.
Jdlrobson edited projects, added Gather Sprint Greatest Hits; removed Gather Sprint Forward.
• JKatzWMF added a project: Mobile-Web-Design.Apr 21 2015, 12:04 AM
• MSyed added a subscriber: • JKatzWMF.Apr 26 2015, 9:39 PM

@JKatzWMF @Jdlrobson

This could be a solution right now.

SeachisSad.png (1×748 px, 38 KB)

Our empty screens for all search pages (desktop and mobile) are pretty awful. Maybe the Search team will take a look at fixing that in the future :)

Jdlrobson updated the task description. (Show Details)Apr 27 2015, 6:19 PM
Jdlrobson updated the task description. (Show Details)Apr 27 2015, 6:21 PM
Jdlrobson edited a custom field.
Jdlrobson moved this task from In Analysis to Ready for dev on the Gather Sprint Greatest Hits board.
Jdlrobson removed • MSyed as the assignee of this task.Apr 27 2015, 6:48 PM
Jdlrobson added a subscriber: • jhobs.Apr 29 2015, 10:56 PM

@jhobs this card would be a great way into understanding our codebase. Please assign it to yourself if you are interested in taking it on.

• jhobs claimed this task.Apr 29 2015, 11:00 PM
Jdlrobson moved this task from Ready for dev to In development on the Gather Sprint Greatest Hits board.Apr 29 2015, 11:28 PM
Jdlrobson moved this task from This Sprint to In sprint on the Gather board.Apr 30 2015, 5:35 PM
Jdlrobson added a comment.May 6 2015, 8:58 PM

@jhobs did you get your Vagrant working? Note to use Gather you'll need to opt in to the mobile beta via Special:MobileOptions.

gerritbot subscribed.May 8 2015, 1:23 PM

Change 209721 had a related patch set uploaded (by Jhobs):
T95966 - Display a message for no search results

https://gerrit.wikimedia.org/r/209721

gerritbot added a project: Patch-For-Review.May 8 2015, 1:23 PM
• jhobs added a comment.May 8 2015, 1:24 PM

@Jdlrobson

Took some fiddling around and eventually a destroy & fresh clone, but yeah I got it working. I uploaded the patch[1], but I think it's currently a candidate for -1 based on i18n. I'm unsure of how to update the failed search query in the template in a way that is i18n-friendly (see "gather-overlay-search-results-empty" in qqq.json).

[1] - https://gerrit.wikimedia.org/r/#/c/209721/

• jhobs moved this task from In development to Code review needed on the Gather Sprint Greatest Hits board.May 8 2015, 1:25 PM
gerritbot added a comment.May 8 2015, 6:26 PM

Change 209721 had a related patch set uploaded (by Jdlrobson):
Display a message for no search results

https://gerrit.wikimedia.org/r/209721

Jdlrobson moved this task from Code review needed to Needs more development (-1) on the Gather Sprint Greatest Hits board.May 8 2015, 6:27 PM
• jhobs moved this task from Needs more development (-1) to Code review needed on the Gather Sprint Greatest Hits board.May 8 2015, 8:37 PM
Jdlrobson moved this task from Code review needed to Ready for signoff on the Gather Sprint Greatest Hits board.May 8 2015, 9:25 PM
gerritbot added a comment.May 8 2015, 9:26 PM

Change 209721 merged by jenkins-bot:
Display a message for no search results

https://gerrit.wikimedia.org/r/209721

Diffusion mentioned this in rMEXT830cb6a8151d: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….May 8 2015, 9:26 PM
• jhobs mentioned this in rEGAT5bb423a452ae: Display a message for no search results.May 8 2015, 9:26 PM
• JKatzWMF closed this task as Resolved.May 8 2015, 11:55 PM
• JKatzWMF moved this task from Ready for signoff to Done on the Gather Sprint Greatest Hits board.
• JKatzWMF closed subtask T98642: Message under search for search in collections with no members is confusing as Resolved.May 21 2015, 4:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL