Instead of ordering by title, we should change It so that pages get ordered in the following way:
FYI: Note ideally we would sort by time they were added to the collection but we'll do that later. See T95786
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/extensions/Gather | master | +208 -24 | Add sort "namespace,title" sort option for listpages |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Invalid | Tgr | T95786 Collection items should be sorted by modified time not alphabetically. | |||
| Duplicate | None | T94255 UI for reordering collections | |||
| Duplicate | None | T94117 API: support page reordering | |||
| Resolved | Tgr | T95972 API: Change default ordering of page titles namespace | |||
| Resolved | Tgr | T98490 Add (list, title) index for Gather lists | |||
| Resolved | Tgr | T96904 PHPUnit tests do not get run by Jenkins for Gather commits |
@Yurik query would be like http://localhost:8888/w/api.php?action=query&list=listpages&lspid=18
Current response
{
"query": {
"listpages": [
{
"ns": 2,
"title": "User:Jdlrobson"
},
{
"ns": 0,
"title": "Headings"
},
{
"ns": 3,
"title": "User talk:Jdlrobson"
},
{
"ns": 8,
"title": "MediaWiki:Jdlrobson"
},
{
"ns": 14,
"title": "Category:Jdlrobson"
},
{
"ns": 14,
"title": "Category:Jdlrobson 2"
},
{
"ns": 1,
"title": "Talk:Jdlrobson"
}
]
}
}Expected response:
{
"query": {
"listpages": [
{
"ns": 0,
"title": "Headings"
},
{
"ns": 1,
"title": "Talk:Jdlrobson"
}
{
"ns": 2,
"title": "User:Jdlrobson"
},
{
"ns": 3,
"title": "User talk:Jdlrobson"
},
{
"ns": 8,
"title": "MediaWiki:Jdlrobson"
},
{
"ns": 14,
"title": "Category:Jdlrobson"
},
{
"ns": 14,
"title": "Category:Jdlrobson 2"
}
]
}
}I was hoping https://gist.github.com/jdlrobson/cc3ed6592b3334d66a57 would do it but it seems the API takes over sorting of the results... what am I doing wrong?
When used as a generator, there is no real sorting. Just like it doesn't
matter in what order you give the "titles" parameter. Your approach would
work for non generator use, and for generator, the "sets" of pages it will
return will be in the right order, but not the titles themselves inside one
result. In other words, simply sort them on the client.
You will have to fix the patch to also order by title, because gli_order is
a unique field, but namespace is not. So continuation is broken
sigh.
Why does the generator not have a concept of sorting? I'd need to do this both on frontend and client and that just sounds horrible.
Generator does have a concept of sorting - it yields batches of page titles
in the given order. The output's <pages> xml/JSON element is a dictionary
of
{pageid:{page properties}, ...}``` elements, so they get sorted by the
numeric ID of the page.Change 209123 had a related patch set uploaded (by Gergő Tisza):
Add sort "namespace,title" sort option for listpages
Moving out of sprint. Seems close to completion though so hopefully with those tests we can get this merged sometime soon.
Change 209123 merged by jenkins-bot:
Add sort "namespace,title" sort option for listpages