Page MenuHomePhabricator

[Task] Use one instance of EntityContentFactory in SpecialWikibaseQueryPage derivative pages
Closed, InvalidPublic

Description

When formatting each row in SpecialWikibaseQueryPage derivative special pages, we do:

WikibaseRepo::getDefaultInstance()->getEntityContentFactory()->getTitleForId( $entry );

while I realize it's difficult to inject dependencies in these special pages, it would still be nice to somehow have one instance of EntityContentFactory.

the WikibaseRepo factory doesn't do any in process caching of this. That could be one place/way to fix, though somehow think it can also be better in the special pages.

Event Timeline

aude created this task.Apr 14 2015, 4:34 PM
aude updated the task description. (Show Details)
aude raised the priority of this task from to Normal.
aude added a subscriber: aude.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 14 2015, 4:34 PM
JanZerebecki set Security to None.
JanZerebecki moved this task from incoming to ready to go on the Wikidata board.

Hmm, I don't seem to be able to find these calls now...?
Any chance we could have some specific files / lines?

Jonas renamed this task from Use one instance of EntityContentFactory in SpecialWikibaseQueryPage derivative pages to [Task] Use one instance of EntityContentFactory in SpecialWikibaseQueryPage derivative pages.Aug 14 2015, 8:17 AM
Addshore closed this task as Invalid.Aug 14 2015, 8:23 AM
Addshore claimed this task.

There are no calls to getEntityContentFactory in any of the repo special pages

There are also only 3 calls to getTitleForId but these are called on titleLookup objects