Page MenuHomePhabricator

ContactPage can't handle label-raw fields during form submission
Closed, ResolvedPublic

Description

It always looks for 'label-message' or otherwise assumes 'label' is set, triggering warnings on form submission for every field you have with label-raw (See https://gerrit.wikimedia.org/r/#/c/59439/ which added label-raw). You can't just set 'label' because that would override label-raw in HTMLForm.
Also the output email looks ridiculous, because the field labels are blank.

Event Timeline

Krenair raised the priority of this task from to Needs Triage.
Krenair updated the task description. (Show Details)
Krenair added subscribers: Krenair, Reedy.

Change 204188 had a related patch set uploaded (by Alex Monk):
Add custom label text setting to be used for email output

https://gerrit.wikimedia.org/r/204188

So it's now possible to still get field names (and not raise warnings) on the output of a ContactPage form where you use label-raw. We can use this in T95789 for giving a very simple output rather than trying to include all of the rendered messages etc.

Change 204188 merged by jenkins-bot:
Add custom label text setting to be used for email output

https://gerrit.wikimedia.org/r/204188