Page MenuHomePhabricator
Create Task
Maniphest T96092

Listed items get deleted upon drag-dropping them
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Create a list of items , numbered or bullet list.

For example:

  • First
  • Second
  • Third
  1. Now select both the items together and now drag them and try to place them in some other position in the document

Observed Result:

The following error appears in the console and the entire list gets deleted.
Uncaught Error: Inserted data is trying to close the root node (at index 6)

List_getting_deleted.mov1 MBDownload

Details

SubjectRepoBranchLines +/-
ve.ce.Surface: Wrap internal drop's insertContent in a try/catchVisualEditor/VisualEditormaster+17 -5
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Apr 14 2015, 10:09 PM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 14 2015, 10:09 PM
Ryasmeen triaged this task as High priority.Apr 14 2015, 10:10 PM
Ryasmeen set Security to None.
Ryasmeen updated the task description. (Show Details)Apr 14 2015, 10:15 PM
Jdforrester-WMF moved this task from To Triage to External and Administrivia on the VisualEditor board.Apr 16 2015, 9:20 PM
Jdforrester-WMF moved this task from External and Administrivia to Freezer on the VisualEditor board.Jun 18 2015, 12:17 AM
Jdforrester-WMF moved this task from Freezer to To Triage on the VisualEditor board.Jul 21 2015, 6:48 PM
Jdforrester-WMF added a project: VisualEditor-EditingTools.Aug 18 2015, 7:16 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
gerritbot subscribed.Sep 11 2015, 1:17 PM

Change 237644 had a related patch set uploaded (by Esanders):
Wrap interal drop's insertContent in a try/catch

https://gerrit.wikimedia.org/r/237644

gerritbot added a project: Patch-For-Review.Sep 11 2015, 1:17 PM
Jdforrester-WMF assigned this task to Esanders.Sep 11 2015, 2:59 PM
Jdforrester-WMF edited a custom field.
gerritbot added a comment.Sep 11 2015, 3:14 PM

Change 237644 merged by jenkins-bot:
ve.ce.Surface: Wrap internal drop's insertContent in a try/catch

https://gerrit.wikimedia.org/r/237644

Jdforrester-WMF mentioned this in rGVEDcfacd18fe940: ve.ce.Surface: Wrap internal drop's insertContent in a try/catch.Sep 11 2015, 3:14 PM
Jdforrester-WMF closed this task as Resolved.Sep 11 2015, 4:20 PM
Jdforrester-WMF edited projects, added WMF-deploy-2015-09-15_(1.26wmf23); removed Patch-For-Review.
Ryasmeen reopened this task as Open.Sep 14 2015, 9:25 PM

The issue of Drag-drop of listed items causing the content to be lost is fixed now. From the fix, I understand it also wont let user perform drag-drop with lists by reverting the action? Correct me if its not supposed to be like that. For now, I am going to mark this issue as verified from QA side.

Ryasmeen added a project: Verified-in-Phase0.Sep 14 2015, 9:25 PM
Ryasmeen closed this task as Resolved.Sep 14 2015, 10:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL