Page MenuHomePhabricator

Update the MobileApps service to the latest version of the service template
Closed, ResolvedPublic

Description

The latest version of service-template-node brings support for proxy, as well CORS and CSP headers, important for security. Please update your service to the latest version and test it thoroughly. In particular, we need to be sure that the correct CSP headers are sent to mobile browsers.

Event Timeline

mobrovac assigned this task to bearND.
mobrovac raised the priority of this task from to Needs Triage.
mobrovac updated the task description. (Show Details)
mobrovac added a subscriber: mobrovac.
mobrovac set Security to None.
mobrovac added a subscriber: bearND.
mobrovac raised the priority of this task from High to Unbreak Now!.Apr 21 2015, 12:52 PM

@bearND ping? Can we get this done ASAP? This task should be as easy as:

git remote add template git@github.com:wikimedia/service-template-node.git
git fetch --all
git merge --squash template/master
# fix conflicts
git commit -am "Update service-template-node to v0.1.3"
git review -R

The important part is testing. The new version includes new CSP headers for which we need evaluation against Android browsers.

Change 205863 had a related patch set uploaded (by Mobrovac):
Update to service-template-node 0.1.3

https://gerrit.wikimedia.org/r/205863

The above patch makes the needed changes. Please review it and test it with your Android/iOS apps.

Change 205863 merged by Mobrovac:
Update to service-template-node 0.1.3

https://gerrit.wikimedia.org/r/205863

mobrovac removed a subscriber: gerritbot.

@bearND confirms the content is displaying correctly, so resolving.