Page MenuHomePhabricator
Create Task
Maniphest T96167

Deleting a collection should not have an associated route
Closed, ResolvedPublic
Actions

Description

Especially now the delete button is inside the overlay - the delete confirmation box should appear overlayed on top of the editor overlay - it shouldn't cause it to close.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Gathermaster+16 -5Do not use a url for the "delete collection" confirmation dialog
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Apr 15 2015, 5:24 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Gather Sprint Forward.
Jdlrobson moved this task to In Analysis on the Gather Sprint Forward board.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2015, 5:24 PM
Jdlrobson moved this task from In Analysis to Ready for dev on the Gather Sprint Forward board.Apr 16 2015, 4:58 PM
Jhernandez claimed this task.Apr 21 2015, 3:58 PM
Jhernandez moved this task from Ready for dev to In development on the Gather Sprint Forward board.
gerritbot added a subscriber: gerritbot.Apr 21 2015, 5:10 PM

Change 205637 had a related patch set uploaded (by Jhernandez):
Do not use a url for the "delete collection" confirmation dialog

https://gerrit.wikimedia.org/r/205637

gerritbot added a project: Patch-For-Review.Apr 21 2015, 5:10 PM
Jhernandez moved this task from In development to Code review needed on the Gather Sprint Forward board.Apr 21 2015, 5:10 PM
Jhernandez added a parent task: T96294: Deleting a collection doesn't close editor overlay.Apr 22 2015, 11:52 AM
Jdlrobson moved this task from Code review needed to Ready for signoff on the Gather Sprint Forward board.Apr 22 2015, 8:13 PM
gerritbot added a comment.Apr 22 2015, 8:19 PM

Change 205637 merged by jenkins-bot:
Do not use a url for the "delete collection" confirmation dialog

https://gerrit.wikimedia.org/r/205637

Diffusion mentioned this in rEGAT13aa0d664b55: Do not use a url for the "delete collection" confirmation dialog.Apr 22 2015, 8:20 PM
Diffusion mentioned this in rMEXT051358fe72e9: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….
• JKatzWMF closed this task as Resolved.Apr 27 2015, 4:43 AM
• JKatzWMF set Security to None.
• JKatzWMF moved this task from Ready for signoff to Done on the Gather Sprint Forward board.
Jdlrobson reopened this task as Open.May 7 2015, 3:53 PM

This bug has come back.

Jdlrobson claimed this task.May 7 2015, 3:53 PM
Jdlrobson added a project: Gather Sprint Greatest Hits.
Jdlrobson moved this task from In Analysis to Code review needed on the Gather Sprint Greatest Hits board.
Jdlrobson added a subscriber: Jhernandez.
• rmoen moved this task from Code review needed to Ready for signoff on the Gather Sprint Greatest Hits board.May 7 2015, 8:02 PM
• rmoen mentioned this in rEGAT941b40b2528a: Fix delete overlay.May 7 2015, 8:09 PM
Diffusion mentioned this in rMEXT621e67192dc4: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….May 7 2015, 8:10 PM
Jdlrobson closed this task as Resolved.May 7 2015, 9:55 PM
Jdlrobson moved this task from Ready for signoff to Done on the Gather Sprint Greatest Hits board.
Jdlrobson mentioned this in rEGATa2d63bec028b: Fix delete overlay.May 7 2015, 10:27 PM
Jdlrobson mentioned this in rEGATab26bfd6fc0c: Fix delete overlay.May 7 2015, 10:31 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL