Page MenuHomePhabricator
Create Task
Maniphest T96186

[EPIC] Move VisualEditor code from MobileFrontend to VisualEditor
Open, LowPublic40 Estimated Story Points
Actions

Description

The following should be moved from MobileFrontend to VisualEditor:

  • javascripts/modules/editor/VisualEditorOverlay.js
  • tests/browsers/features/editor_ve.feature

This is harder than it seems on the surface but let's aim to do this and in the process hopefully rewrite a lot of our infrastructure in oojs ui.

The benefits of this include

  • more stable browser tests that the VisualEditor team will be able to keep an eye on that don't hide false positives in our own product.
  • smaller extension for third parties who don't use VE
  • less bugs in VisualEditor tablet software due to our code clashing with VE code.
  • no tests filed against the mobile web backlog which would lead to a cleaner Phabricator board
  • research through doing about how mobile can use oojs ui and identify the problems we need to solve to do that.

To do this I would suggest the following steps (which may need fleshing out and may uncover additional work/spikes)

  • rewrite the header of VisualEditorOverlay as oojs ui components
  • rewrite the edit summary pane as a Oojs ui component
  • rewrite VisualEditorOverlay as a oo.ui.ProcessDialog
  • Move all VisualEditor code to VisualEditor extension - browser tests, js, css, RL modules

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendmaster+0 -70Delete save process code in favour of VE's own save dialog
mediawiki/extensions/VisualEditormaster+336 -286[BREAKING CHANGE] Use save dialog in mobile
mediawiki/extensions/MobileFrontendmaster+188 -149VisualEditor: Create a MF target and move code into method overrides
mediawiki/extensions/VisualEditormaster+84 -22Bring in code from MobileFrontend
mediawiki/extensions/MobileFrontendmaster+27 -62Move more code to VE
mediawiki/extensions/VisualEditormaster+146 -66[BREAKING CHANGE] Bring in some code from MobileFrontend
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT106267 mobile phone wikitext editor should have edit toolbar
 OpenNoneT106266 Provide a "signature" button in the mobile wikitext editor
 OpenNoneT171974 Improve and consolidate our unified editing platform so that it's great on all devices
 OpenNoneT159971 Provide the VE wikitext editing mode as the mobile wikitext editor
 OpenNoneT158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web
 DeclinedNoneT144571 Mobile Media Viewer violates user settings
 OpenJdlrobsonT65504 Consolidate code for MediaViewer across desktop and mobile
 DeclinedNoneT162210 [EPIC] Upstream MobileFrontend components to core and other extensions (tracking)
 DuplicateJdlrobsonT66316 [EPIC] Move Nearby code to more suitable extension
 OpenNoneT49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core
 OpenNoneT100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core
 DeclinedNoneT96202 [EPIC] Rewrite MobileFrontend frontend code in OOUI
 DuplicateNoneT101462 [EPIC] Merge OOJS UI library and Mobile unnamed library.
 OpenNoneT96186 [EPIC] Move VisualEditor code from MobileFrontend to VisualEditor
 ResolvedJdlrobsonT86366 Revisit box-sizing: border-box for everything in MobileFrontend
 DeclinedNoneT88559 VisualEditorOverlay should be written as an OO.ui.ProcessDialog
 ResolvedEsandersT96187 Rewrite VisualEditorOverlay header using OOjs UI
 ResolvedEsandersT96188 Rewrite the edit summary screen of VisualEditorOverlay in OOjs UI
ResolvedmatmarexT198765 Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop)
 ResolvedmatmarexT202978 Move MobileFrontend's VisualEditor styles back to MobileFrontend
 ResolvedovasilevaT205382 Remove code related to no-anonymous-editing mode of MobileFrontend ($wgMFEditorOptions['anonymousEditing'] = false;)
 ResolvedABorbaWMFT208514 Merge PageIssues Feature Branch to Master
 ResolvedNoneT206178 Feature branch: Remove pageIssues A-B test code

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Jdlrobson set Security to None.Apr 15 2015, 8:59 PM
Jdlrobson added a parent task: T88559: VisualEditorOverlay should be written as an OO.ui.ProcessDialog.
Jdlrobson updated the task description. (Show Details)Apr 15 2015, 9:05 PM
Jdlrobson removed a parent task: T88559: VisualEditorOverlay should be written as an OO.ui.ProcessDialog.
Jdlrobson removed a parent task: T86366: Revisit box-sizing: border-box for everything in MobileFrontend.
Jdlrobson added subtasks: T86366: Revisit box-sizing: border-box for everything in MobileFrontend, T88559: VisualEditorOverlay should be written as an OO.ui.ProcessDialog.
Jdlrobson moved this task from Triaged but Future to 2016-17 Q1 on the Web-Team-Backlog board.Apr 15 2015, 11:34 PM
Jdlrobson moved this task from 2016-17 Q1 to Triaged but Future on the Web-Team-Backlog board.Apr 16 2015, 12:16 AM
Jdlrobson closed subtask T86366: Revisit box-sizing: border-box for everything in MobileFrontend as Resolved.Apr 16 2015, 5:27 PM
Jdforrester-WMF added projects: VisualEditor, Technical-Debt, VisualEditor 2014/15 Q4 blockers, VisualEditor-MediaWiki-Mobile.Apr 16 2015, 5:30 PM
Jdforrester-WMF moved this task from Nominated to Backlog on the VisualEditor 2014/15 Q4 blockers board.Apr 29 2015, 6:23 PM
Jdforrester-WMF triaged this task as Medium priority.Apr 29 2015, 6:48 PM
Jdforrester-WMF edited a custom field.May 6 2015, 10:09 PM
Jdforrester-WMF moved this task from To Triage to Planned Maintenance on the VisualEditor board.May 8 2015, 1:44 AM
Jdlrobson renamed this task from Move VisualEditor code from MobileFrontend to VisualEditor to [EPIC] Move VisualEditor code from MobileFrontend to VisualEditor.May 26 2015, 8:58 AM
Jdlrobson moved this task from Triaged but Future to 2015-16 Q2 on the Web-Team-Backlog board.
Jdlrobson mentioned this in rEMFR39d93c32f2a0: QA: @skip VisualEditor tests.Jun 2 2015, 11:37 PM
Diffusion mentioned this in rMEXTe337e98abfd1: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Jun 2 2015, 11:37 PM
Tgr added a project: Epic.Jun 4 2015, 10:41 PM
Tgr added a subscriber: Tgr.
Jdlrobson added a parent task: T101462: [EPIC] Merge OOJS UI library and Mobile unnamed library..Jun 4 2015, 11:23 PM
Esanders reopened subtask T86366: Revisit box-sizing: border-box for everything in MobileFrontend as Open.Jun 13 2015, 11:08 AM
Jdforrester-WMF edited projects, added VisualEditor 2015/16 Q1 blockers; removed VisualEditor 2014/15 Q4 blockers.Jun 16 2015, 8:00 PM
Jdforrester-WMF moved this task from Planned Maintenance to Epics on the VisualEditor board.Jun 18 2015, 12:15 AM
Jdforrester-WMF renamed this task from [EPIC] Move VisualEditor code from MobileFrontend to VisualEditor to Move VisualEditor code from MobileFrontend to VisualEditor.Jun 18 2015, 10:28 PM
Jdforrester-WMF edited projects, added Tracking-Neverending; removed Epic.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF removed a project: VisualEditor 2015/16 Q1 blockers.Jul 21 2015, 6:29 PM
• Jhernandez closed subtask T86366: Revisit box-sizing: border-box for everything in MobileFrontend as Resolved.Jul 29 2015, 10:43 AM
gerritbot added a subscriber: gerritbot.Jul 29 2015, 6:36 PM

Change 227699 had a related patch set uploaded (by Jforrester):
[BREAKING CHANGE] Bring in some code from MobileFrontend

https://gerrit.wikimedia.org/r/227699

gerritbot added a project: Patch-For-Review.Jul 29 2015, 6:36 PM
gerritbot added a comment.Jul 29 2015, 11:47 PM

Change 227699 merged by jenkins-bot:
[BREAKING CHANGE] Bring in some code from MobileFrontend

https://gerrit.wikimedia.org/r/227699

• Forrestbot added a project: WMF-deploy-2015-08-04_(1.26wmf17).Jul 30 2015, 12:00 AM
gerritbot added a comment.Jul 30 2015, 1:33 PM

Change 227974 had a related patch set uploaded (by Esanders):
Move more code to VE

https://gerrit.wikimedia.org/r/227974

gerritbot added a comment.Jul 30 2015, 1:52 PM

Change 227973 had a related patch set uploaded (by Esanders):
Bring in code from MobileFrontend

https://gerrit.wikimedia.org/r/227973

gerritbot added a comment.Jul 30 2015, 5:25 PM

Change 227973 merged by jenkins-bot:
Bring in code from MobileFrontend

https://gerrit.wikimedia.org/r/227973

gerritbot added a comment.Jul 30 2015, 5:25 PM

Change 227974 merged by jenkins-bot:
Move more code to VE

https://gerrit.wikimedia.org/r/227974

Esanders mentioned this in rEMFRb8702a8d00c7: Move more code to VE.Jul 30 2015, 10:12 PM
Jdforrester-WMF mentioned this in rEVED3593184f42a5: [BREAKING CHANGE] Bring in some code from MobileFrontend.Jul 30 2015, 10:13 PM
Krenair mentioned this in rEVEDd2c15e9eb534: Bring in code from MobileFrontend.Jul 30 2015, 10:13 PM
Diffusion mentioned this in rMEXTaa72b6724e16: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Jul 30 2015, 10:16 PM
Jdforrester-WMF edited a custom field.Aug 3 2015, 1:56 AM
gerritbot added a comment.Aug 4 2015, 1:41 PM

Change 229124 had a related patch set uploaded (by Esanders):
Create a MF target and move code into method overrides

https://gerrit.wikimedia.org/r/229124

Jdlrobson renamed this task from Move VisualEditor code from MobileFrontend to VisualEditor to [EPIC] Move VisualEditor code from MobileFrontend to VisualEditor.Aug 4 2015, 6:51 PM
gerritbot added a comment.Aug 5 2015, 12:57 AM

Change 229124 merged by jenkins-bot:
VisualEditor: Create a MF target and move code into method overrides

https://gerrit.wikimedia.org/r/229124

Esanders mentioned this in rMEXT4db8341f6ef2: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Aug 5 2015, 12:58 AM
Jdlrobson mentioned this in rEMFR709571690026: VisualEditor: Create a MF target and move code into method overrides.Aug 5 2015, 12:58 AM
• Forrestbot added a project: WMF-deploy-2015-08-11_(1.26wmf18).Aug 5 2015, 1:00 AM
gerritbot added a comment.Aug 5 2015, 9:49 PM

Change 229576 had a related patch set uploaded (by Esanders):
[BREAKING CHANGE] Use save dialog in mobile

https://gerrit.wikimedia.org/r/229576

gerritbot added a comment.Aug 5 2015, 9:51 PM

Change 229578 had a related patch set uploaded (by Esanders):
Delete save process code in favour of VE's own save dialog

https://gerrit.wikimedia.org/r/229578

gerritbot added a comment.Aug 6 2015, 9:57 PM

Change 229576 merged by jenkins-bot:
[BREAKING CHANGE] Use save dialog in mobile

https://gerrit.wikimedia.org/r/229576

Jdforrester-WMF mentioned this in rEVED707628cfb1d8: [BREAKING CHANGE] Use save dialog in mobile.Aug 6 2015, 9:58 PM
gerritbot added a comment.Aug 6 2015, 10:06 PM

Change 229578 merged by jenkins-bot:
Delete save process code in favour of VE's own save dialog

https://gerrit.wikimedia.org/r/229578

Esanders mentioned this in rEMFR656fcf1803d2: Delete save process code in favour of VE's own save dialog.Aug 6 2015, 10:06 PM
Diffusion mentioned this in rMEXTb2823c1bf14d: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Aug 6 2015, 10:06 PM
Jdforrester-WMF assigned this task to Esanders.Aug 6 2015, 11:19 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jay8g added a subscriber: Jay8g.Aug 12 2015, 11:30 PM
Jdlrobson added a parent task: T96202: [EPIC] Rewrite MobileFrontend frontend code in OOUI.Aug 14 2015, 12:13 AM
Esanders reopened subtask T86366: Revisit box-sizing: border-box for everything in MobileFrontend as Open.Aug 15 2015, 11:46 AM
• Jhernandez edited projects, added MobileFrontend; removed Web-Team-Backlog.Aug 17 2015, 11:42 AM
Jdforrester-WMF removed Esanders as the assignee of this task.Nov 19 2015, 7:00 PM
Danny_B moved this task from Unsorted to Move on the Technical-Debt board.Jan 23 2016, 12:18 AM
Danny_B added a project: Epic.May 6 2016, 7:48 PM
Danny_B moved this task from Tag to Should be Epic instead on the Tracking-Neverending board.May 27 2016, 4:54 PM
Jdlrobson moved this task from Backlog to Team:Editing on the MobileFrontend board.Nov 14 2016, 11:57 AM
Deskana removed a project: Tracking-Neverending.Apr 20 2018, 3:05 PM
Deskana lowered the priority of this task from Medium to Low.Aug 31 2018, 10:32 AM
Deskana moved this task from Epics to Freezer on the VisualEditor board.
Jdlrobson added a subtask: T198765: Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop).Sep 14 2018, 5:24 PM
Jdlrobson added a subtask: T202978: Move MobileFrontend's VisualEditor styles back to MobileFrontend.
• Niedzielski added a subscriber: • Niedzielski.Sep 14 2018, 5:38 PM
• marcella moved this task from Freezer to Needs Discussion/Analysis on the VisualEditor board.Sep 19 2018, 1:44 PM
Deskana closed subtask T202978: Move MobileFrontend's VisualEditor styles back to MobileFrontend as Resolved.Sep 27 2018, 1:30 PM
JTannerWMF moved this task from Needs Discussion/Analysis to Planned Maintenance on the VisualEditor board.Sep 27 2018, 3:12 PM
JTannerWMF assigned this task to • marcella.Sep 27 2018, 3:40 PM
JTannerWMF moved this task from Planned Maintenance to Research on the VisualEditor board.
JTannerWMF moved this task from Research to Planned Maintenance on the VisualEditor board.
matmarex changed the status of subtask T198765: Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop) from Open to Stalled.Oct 26 2018, 6:50 PM
matmarex changed the status of subtask T198765: Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop) from Stalled to Open.Nov 8 2018, 6:11 PM
JTannerWMF moved this task from Planned Maintenance to Epics on the VisualEditor board.Dec 12 2018, 2:53 PM
Jdlrobson closed subtask T86366: Revisit box-sizing: border-box for everything in MobileFrontend as Resolved.Jan 9 2019, 6:51 PM
matmarex closed subtask T88559: VisualEditorOverlay should be written as an OO.ui.ProcessDialog as Declined.Feb 6 2019, 4:22 PM
ppelberg closed subtask T198765: Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop) as Resolved.Mar 13 2019, 6:57 PM
Jdlrobson moved this task from Team:Editing to Epics on the MobileFrontend board.Jul 24 2020, 3:12 PM
Aklapper removed • marcella as the assignee of this task.Jan 9 2022, 10:28 PM
Aklapper added a subscriber: • marcella.

(Removing inactive task assignee)

Aklapper added a comment.Jan 9 2022, 10:30 PM

For the records, all subtasks are closed and all patches are merged. Not sure this should remain open.

Jdlrobson added a project: Editing-team.Jan 10 2022, 7:19 PM
Jdlrobson added a subscriber: Esanders.

I don't think any tickets got opened.

@Esanders is there any motivation/interest from the editing team to pull out the MobileFrontend code relating to the editor into VisualEditor extension as a joint initiative in the interest of better code boundaries ?

In the long term, the web team would be interested in porting all the components to Vue.js, so curious what your plan for the editing team maintained code is.

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL