The mobile context that comes out of the bottom of the toolbar needs to not push the content down when activated, but instead occupy an already reserved space. This isn't a problem when the toolbar is floating.
Description
Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | matmarex | T221328 [Epic] Mobile VE usability improvements (FY18-19 Q4) | |||
Open | None | T209505 EPIC: Fix selection issues on mobile | |||
Resolved | • ppelberg | T136840 Selection dragging opens context menu on mobile, causing surface to move and breaking drag in Android Chrome | |||
Resolved | • ppelberg | T221723 iOS Safari: After inserting a link, the selection often ends up hidden by the keyboard | |||
Resolved | matmarex | T96289 Fix the jump when opening the mobile context |
Event Timeline
Change 508460 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] ve.ce.Surface: Add 'dragging' event
Change 508461 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.init.mw.MobileArticleTarget: Fix the jump when opening the mobile context
The above seemed to work great when I tested on desktop. On iOS it has some weird interaction with our scrolling hacks, and sometimes the page still goes crazy when trying to place a selection (not sure if this is due to iOS Safari bugs, or also our scrolling hacks). I don't have an Android device with me right now to test.
Overall I am not sure how good this is. If we're definitely doing T204733 T221247, then maybe we should just wait for that, as that redesign should magically fix this problem.
@ppelberg, given matmarex's comment above, would you like us to continue to prioritize work on this or wait for the outcomes of the mobile context repositioning that's also happening this quarter?
As we have deployed the new edit cards to bn/he/fa we can just QA them on those wikis?
Change 508461 abandoned by Esanders:
ve.init.mw.MobileArticleTarget: Fix the jump when opening the mobile context
Reason:
Unnecessary with new edit cards.
Change 508460 abandoned by Bartosz Dziewoński:
ve.ce.Surface: Add 'dragging' event
Reason:
Not needed if we're not doing https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/ /508461
@matmarex: If I understand correctly this issue is now obsolete with the implementation of new Edit Cards design. What's here for me to test exactly?