Page MenuHomePhabricator

VE Inspectors in mobile should have a "cancel" or "back" button
Closed, DuplicatePublic

Description

In mobile, inspectors grow to the full size of the screen, but they don't have a "back" or "cancel" button, so it's impossible to cancel the operation.

Reproduce (especially valid to Citoid)

  1. Open VE in mobile
  2. Click Cite icon -> Cite
  3. Try to go back to the document.

Event Timeline

Mooeypoo raised the priority of this task from to Needs Triage.
Mooeypoo updated the task description. (Show Details)
Mooeypoo subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Aklapper renamed this task from VE Inspectors in movile should have a "cancel" or "back" buttons to VE Inspectors in mobile should have a "cancel" or "back" button.Apr 17 2015, 12:26 PM
Aklapper set Security to None.
Jdforrester-WMF subscribed.

Can we do this by overriding the default behaviour of the window manager?

As discussed with Trevor and Roan. the conclusion is that this should follow the same method that dialogs are using -- that is, the inspectors already have a safe action set, but inspectors seem to override it at will. It should be the responsibility of the inspector maker to make sure that if they override the default actions, they leave a "cancel" button on, just like in dialogs.

Change 205312 had a related patch set uploaded (by Mooeypoo):
Add a cancel action to the Citoid inspector

https://gerrit.wikimedia.org/r/205312

Note about usability of this -- this can be added to all inspectors except for the Annotation Inspectors, since those automatically add the content. So while the 'safe' action is exactly the same as dismissing the inspector by clicking away from it, we can't call that action "cancel" in the link and language inspectors, because clicking away and dismissing the inspector doesn't cancel the action, it merely closes the inspector.

We should re-evaluate, for consistency's sake if nothing else, if we really want the Annotation inspectors to automatically add content rather than stage the changes and allow the user to cancel completely by clicking away or apply by clicking apply.

Either way, right now the annotation inspectors will have to keep their own safe action with the "Done" button they already have, unless (and until) we change this behavior, and can add a "cancel" button that actually cancels the action.

Change 205339 had a related patch set uploaded (by Mooeypoo):
Add a default 'cancel' action to FragmentInspectors

https://gerrit.wikimedia.org/r/205339

Change 205312 merged by jenkins-bot:
Add a cancel action to the Citoid inspector

https://gerrit.wikimedia.org/r/205312

Change 205339 merged by jenkins-bot:
Add a default 'cancel' action to FragmentInspectors

https://gerrit.wikimedia.org/r/205339

Change 205353 had a related patch set uploaded (by Mooeypoo):
Followup Id9e9c7: Add 'cancel' in AnnotationInspector 'insert' mode

https://gerrit.wikimedia.org/r/205353

Change 205353 merged by jenkins-bot:
Followup Id9e9c7: Add 'cancel' in AnnotationInspector 'insert' mode

https://gerrit.wikimedia.org/r/205353