Page MenuHomePhabricator

Clean up usage of ApiResult in tests and ResultBuilder
Closed, ResolvedPublic

Description

@Anomie noted the following remaining todos on https://gerrit.wikimedia.org/r/#/c/197383/ :

  • Remove hardcoded '_element' in favor of ApiResult constants and/or methods.
  • Have unit tests pass without passing flags to ApiResult::getResultData(). Although you may want to wait on that for I35007089 to land, since it will be adding some default metadata to all results.
  • If you don't like the static calls, you should be able to do `new ApiResult( false )` and populate it using the non-static methods instead of using an array() with the static methods.

Event Timeline

daniel raised the priority of this task from to Needs Triage.
daniel updated the task description. (Show Details)
daniel added subscribers: daniel, Anomie.
JanZerebecki set Security to None.
JanZerebecki moved this task from incoming to ready to go on the Wikidata board.

Change 224428 had a related patch set uploaded (by Addshore):
Simplify use of Result::getResultData in ResultBuilderTest

https://gerrit.wikimedia.org/r/224428

Change 224428 merged by jenkins-bot:
Simplify use of Result::getResultData in ResultBuilderTest

https://gerrit.wikimedia.org/r/224428

afaik all of this is now tidied / done