Page MenuHomePhabricator

Clear more things from memory when ManagerGroup::clear() is called
Closed, ResolvedPublic

Description

The FlowForceSearchIndex script, over the course of running, pulls in pretty much every revision ever created in Flow. I noticed while running this that even when calling the ObjectManager clear() method memory continued to expand. The attached patches don't 100% resolve the issue, but help by clearing out a few more things when using the clear method:

https://gerrit.wikimedia.org/r/204675
https://gerrit.wikimedia.org/r/204676
https://gerrit.wikimedia.org/r/204677
https://gerrit.wikimedia.org/r/204683

Event Timeline

EBernhardson updated the task description. (Show Details)
EBernhardson raised the priority of this task from to Normal.
EBernhardson added a subscriber: EBernhardson.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 17 2015, 4:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 204675 had a related patch set uploaded (by EBernhardson):
Add an AbstractListener base class

https://gerrit.wikimedia.org/r/204675

Change 204676 had a related patch set uploaded (by EBernhardson):
Add an onAfterClear data event

https://gerrit.wikimedia.org/r/204676

Change 204677 had a related patch set uploaded (by EBernhardson):
Use the Workflow mapper in UrlGenerator

https://gerrit.wikimedia.org/r/204677

Change 204683 had a related patch set uploaded (by EBernhardson):
Fetch Storage from ManagerGroup every time

https://gerrit.wikimedia.org/r/204683

DannyH closed this task as Resolved.Apr 17 2015, 5:11 PM
DannyH claimed this task.
DannyH reopened this task as Open.

sorry, my bad

DannyH reassigned this task from DannyH to EBernhardson.Apr 17 2015, 5:14 PM
DannyH set Security to None.

Change 204675 merged by jenkins-bot:
Add an AbstractListener base class

https://gerrit.wikimedia.org/r/204675

Change 204676 merged by jenkins-bot:
Add an onAfterClear data event

https://gerrit.wikimedia.org/r/204676

Change 204683 merged by jenkins-bot:
Fetch Storage from ManagerGroup every time

https://gerrit.wikimedia.org/r/204683

Change 204677 merged by jenkins-bot:
Use the Workflow mapper in UrlGenerator

https://gerrit.wikimedia.org/r/204677

matthiasmullie closed this task as Resolved.
matthiasmullie added a subscriber: matthiasmullie.