Page MenuHomePhabricator
Create Task
Maniphest T96388

Clear more things from memory when ManagerGroup::clear() is called
Closed, ResolvedPublic
Actions

Description

The FlowForceSearchIndex script, over the course of running, pulls in pretty much every revision ever created in Flow. I noticed while running this that even when calling the ObjectManager clear() method memory continued to expand. The attached patches don't 100% resolve the issue, but help by clearing out a few more things when using the clear method:

https://gerrit.wikimedia.org/r/204675
https://gerrit.wikimedia.org/r/204676
https://gerrit.wikimedia.org/r/204677
https://gerrit.wikimedia.org/r/204683

Details

SubjectRepoBranchLines +/-
Use the Workflow mapper in UrlGeneratormediawiki/extensions/Flowmaster+14 -58
Fetch Storage from ManagerGroup every timemediawiki/extensions/Flowmaster+3 -12
Add an onAfterClear data eventmediawiki/extensions/Flowmaster+35 -0
Add an AbstractListener base classmediawiki/extensions/Flowmaster+56 -101
Customize query in gerrit

Related Objects

Event Timeline

EBernhardson created this task.Apr 17 2015, 4:46 PM
EBernhardson raised the priority of this task from to Medium.
EBernhardson updated the task description. (Show Details)
EBernhardson added projects: StructuredDiscussions, Collaboration-Team-Sprint-U-2015-04-22.
EBernhardson subscribed.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 17 2015, 4:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
EBernhardson moved this task from Sprint U - ends April 22 to Needs Review on the Collaboration-Team-Sprint-U-2015-04-22 board.Apr 17 2015, 4:46 PM
gerritbot subscribed.Apr 17 2015, 4:47 PM

Change 204675 had a related patch set uploaded (by EBernhardson):
Add an AbstractListener base class

https://gerrit.wikimedia.org/r/204675

gerritbot added a project: Patch-For-Review.Apr 17 2015, 4:47 PM

Change 204676 had a related patch set uploaded (by EBernhardson):
Add an onAfterClear data event

https://gerrit.wikimedia.org/r/204676

gerritbot added a comment.Apr 17 2015, 4:47 PM

Change 204677 had a related patch set uploaded (by EBernhardson):
Use the Workflow mapper in UrlGenerator

https://gerrit.wikimedia.org/r/204677

gerritbot added a comment.Apr 17 2015, 4:47 PM

Change 204683 had a related patch set uploaded (by EBernhardson):
Fetch Storage from ManagerGroup every time

https://gerrit.wikimedia.org/r/204683

• DannyH closed this task as Resolved.Apr 17 2015, 5:11 PM
• DannyH reopened this task as Open.
• DannyH claimed this task.

sorry, my bad

• DannyH reassigned this task from • DannyH to EBernhardson.Apr 17 2015, 5:14 PM
• DannyH set Security to None.
gerritbot added a comment.Apr 20 2015, 6:09 PM

Change 204675 merged by jenkins-bot:
Add an AbstractListener base class

https://gerrit.wikimedia.org/r/204675

Diffusion mentioned this in rMEXT83a912fe7be5: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Apr 20 2015, 6:09 PM
EBernhardson mentioned this in rEFLWb3fbd155e5b9: Add an AbstractListener base class.Apr 20 2015, 6:09 PM
gerritbot added a comment.Apr 22 2015, 8:04 AM

Change 204676 merged by jenkins-bot:
Add an onAfterClear data event

https://gerrit.wikimedia.org/r/204676

Diffusion mentioned this in rMEXTc1a24f141535: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Apr 22 2015, 8:04 AM
EBernhardson mentioned this in rEFLWdb76405b35f0: Add an onAfterClear data event.Apr 22 2015, 8:04 AM
matthiasmullie moved this task from Needs Review to Code Review Started on the Collaboration-Team-Sprint-U-2015-04-22 board.Apr 22 2015, 5:32 PM
• DannyH added a project: Collaboration-Team-Sprint-A-2015-05-06.Apr 22 2015, 7:12 PM
• DannyH moved this task from Sprint A - ends May 6 to Code Review Started on the Collaboration-Team-Sprint-A-2015-05-06 board.
gerritbot added a comment.Apr 22 2015, 7:58 PM

Change 204683 merged by jenkins-bot:
Fetch Storage from ManagerGroup every time

https://gerrit.wikimedia.org/r/204683

gerritbot added a comment.Apr 22 2015, 7:58 PM

Change 204677 merged by jenkins-bot:
Use the Workflow mapper in UrlGenerator

https://gerrit.wikimedia.org/r/204677

EBernhardson mentioned this in rEFLW04377ab95b3f: Fetch Storage from ManagerGroup every time.Apr 22 2015, 7:59 PM
EBernhardson mentioned this in rEFLWcfa3546973dc: Use the Workflow mapper in UrlGenerator.
Diffusion mentioned this in rMEXT2e4857038b30: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Apr 22 2015, 7:59 PM
Diffusion mentioned this in rMEXT2a3f37a86cc2: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….
matthiasmullie moved this task from Code Review Started to QA Review on the Collaboration-Team-Sprint-A-2015-05-06 board.Apr 23 2015, 12:52 PM
matthiasmullie closed this task as Resolved.Apr 23 2015, 5:39 PM
matthiasmullie moved this task from QA Review to Done on the Collaboration-Team-Sprint-A-2015-05-06 board.
matthiasmullie subscribed.
• DannyH moved this task from Untriaged to Resolved on the Collaboration-Team-Triage board.Apr 23 2015, 8:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL