Page MenuHomePhabricator
Create Task
Maniphest T96404

Tapping on lead image should open image in mobile media viewer
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Tapping on lead image should open full, uncropped image in mobile media viewer. Behaves the same as all other images on page.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendmaster+38 -8Make the banner image clickable
Customize query in gerrit

Related Objects

Event Timeline

• KHammerstein created this task.Apr 17 2015, 6:41 PM
• KHammerstein raised the priority of this task from to Needs Triage.
• KHammerstein updated the task description. (Show Details)
• KHammerstein added a project: Readers-Web-Backlog.
• KHammerstein added a subscriber: • KHammerstein.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2015, 6:41 PM
• KLans_WMF moved this task from Incoming to 2014-15 Q4 on the Readers-Web-Backlog board.Apr 20 2015, 4:06 PM
• KLans_WMF moved this task from 2014-15 Q4 to 2015-16 Q3 on the Readers-Web-Backlog board.Apr 29 2015, 8:42 PM
• KHammerstein updated the task description. (Show Details)Apr 29 2015, 8:58 PM
• KHammerstein set Security to None.
phuedx added a subscriber: phuedx.Apr 29 2015, 9:02 PM

The lead image should behave like every other image on the page.

The existing MediaViewer integration for images on mobile (see the mobile.mediaViewer module) should be replicated for the lead image.

• KLans_WMF added a project: Mobile-Web-Sprint-47-Undercover-Brother.May 6 2015, 6:45 PM
• KLans_WMF edited a custom field.
• KLans_WMF moved this task from Needs Analysis to To Do on the Mobile-Web-Sprint-47-Undercover-Brother board.May 6 2015, 6:48 PM
bmansurov claimed this task.May 12 2015, 11:25 PM
gerritbot added a subscriber: gerritbot.May 12 2015, 11:50 PM

Change 210623 had a related patch set uploaded (by Bmansurov):
WIP: Make the banner image clickable

https://gerrit.wikimedia.org/r/210623

gerritbot added a project: Patch-For-Review.May 12 2015, 11:50 PM
bmansurov moved this task from To Do to Doing on the Mobile-Web-Sprint-47-Undercover-Brother board.May 12 2015, 11:50 PM
bmansurov moved this task from Doing to Code Review on the Mobile-Web-Sprint-47-Undercover-Brother board.May 13 2015, 9:51 PM
phuedx moved this task from Code Review to -1 (Needs More Work) on the Mobile-Web-Sprint-47-Undercover-Brother board.May 20 2015, 6:03 PM
bmansurov moved this task from -1 (Needs More Work) to Code Review on the Mobile-Web-Sprint-47-Undercover-Brother board.May 20 2015, 9:25 PM
phuedx moved this task from Code Review to -1 (Needs More Work) on the Mobile-Web-Sprint-47-Undercover-Brother board.May 21 2015, 10:27 AM
bmansurov moved this task from -1 (Needs More Work) to Code Review on the Mobile-Web-Sprint-47-Undercover-Brother board.May 21 2015, 5:32 PM
gerritbot added a comment.May 21 2015, 6:29 PM

Change 210623 merged by jenkins-bot:
Make the banner image clickable

https://gerrit.wikimedia.org/r/210623

Diffusion mentioned this in rMEXT4b84d1d145b5: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….May 21 2015, 6:29 PM
bmansurov mentioned this in rEMFRbde3cff953fe: Make the banner image clickable.May 21 2015, 6:29 PM
phuedx closed this task as Resolved.May 21 2015, 6:37 PM
phuedx removed a project: Patch-For-Review.
phuedx moved this task from Code Review to Ready for Signoff on the Mobile-Web-Sprint-47-Undercover-Brother board.
phuedx moved this task from Ready for Signoff to Done on the Mobile-Web-Sprint-47-Undercover-Brother board.
• Phabricator_maintenance moved this task from 2015-16 Q3 to 2014-15 Q4 on the Readers-Web-Backlog board.Mar 7 2018, 1:19 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL