Page MenuHomePhabricator

Upon edit, a task description which mentions a Phab user (re)adds that Phab user to CC/Subscribers field
Open, LowPublic

Description

Upstream: https://secure.phabricator.com/T11035

See https://phabricator.wikimedia.org/T95135#1217734 : the user had just unsubscribed, but changing projects/summary via the edit window forced them to be subscribed again.

There was some report about comments automatically adding people to subscribers/cc, but with Phabricator's search I'm unable to find it...

Quoting or otherwise mentioning another user in a comment might be more common, but task editing is more important and users shouldn't be scared of improving tasks for the fear of stalking unwilling users.


See Also:
T76993: Quoting shouldn't readd me to a task I've unsubscribed from
T109359: @mentions add subscribers even if they were explicitly unsubscribed already

Event Timeline

Nemo_bis created this task.Apr 18 2015, 6:06 AM
Nemo_bis raised the priority of this task from to Normal.
Nemo_bis updated the task description. (Show Details)
Nemo_bis added a subscriber: Nemo_bis.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 18 2015, 6:06 AM
Aklapper lowered the priority of this task from Normal to Lowest.Apr 18 2015, 7:04 PM
Aklapper raised the priority of this task from Lowest to Low.
Aklapper set Security to None.
Nnemo added a subscriber: Nnemo.Apr 18 2015, 8:11 PM
Qgil added a subscriber: Qgil.Apr 20 2015, 7:31 AM

I think Phabricator just reflects the list of subscribers in a task when it is being edited. In your example above, if you had opened the edit window before the user unsubscribed, they will still appear in your edit window, and it will be subscribed back when you save it.

If this is what you mean, then this is a variant of the 'no mid-air crash' problem (T78236).

No, it's not what I mean. It's about the username being mentioned in the *text* description, not in the subscribers field.

Aklapper renamed this task from Upon edit, a task description mentioning users adds them to CC to Upon edit, a task description which mentions a Phab user (re)adds that Phab user to CC/Subscribers field.Apr 22 2015, 9:30 AM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptMay 22 2016, 2:30 PM

I recall having a similar issue with a comment recently (i.e. not a task description)

Aklapper updated the task description. (Show Details)Nov 17 2016, 6:42 PM
Qgil removed a subscriber: Qgil.Nov 18 2016, 11:07 AM

Current status, quoting upstream comment https://secure.phabricator.com/T11035#180691 from June 2016:

  • editing comments uses the correct rule (only new mentions count).
  • editing other fields still uses the old/wrong rule (all mentions still count).

Fixing the "other fields" case is complicated, per above, and I plan to wait and see how https://secure.phabricator.com/T9789 and adjacent work develop before planning how to continue forward here.

Current status, quoting upstream comment https://secure.phabricator.com/T11035#215569 from March 2017:

This is no longer blocked on anything, I just need to develop a specific technical plan to resolve the "adjust" vs "expand" sequence inside transaction application so the "expand" code has access to the old text by the time it runs.

I would think that this is less important now that tasks have an explicit mute which overrides notifications regardless of subscribed status.