Page MenuHomePhabricator

dbtree loads third party resources (from google.com/jsapi)
Open, Stalled, LowestPublic

Description

https://dbtree.wikimedia.org/ loads stuff from code.jquery.com and google.com/jsapi. It shows only a white page if that domain is blocked by the browser. Please load js from a Wikimedia domain.

If you want to load third -arty resources, per the privacy policy you need a disclaimer somewhere in the page.

Code is in operations/software/dbtree

Event Timeline

Nemo_bis raised the priority of this task from to Medium.
Nemo_bis updated the task description. (Show Details)
Nemo_bis added a subscriber: Nemo_bis.
Nemo_bis set Security to None.

Do we already have jquery sitting on a wikimedia URL?

No, please don't use bits.wikimedia.org outside a MediaWiki context. It hardcodes details outside of the separation of concerns. It also moves the version requirement to an unrelated software package.

Just add a distribution file to the repo that provides this dashboard. E.g. from {docroot}/lib/jquery/jquery-1.9.1.js or something like that.

Aklapper renamed this task from dbtree loads third party resources to dbtree loads third party resources (from jquery.com).May 19 2015, 12:56 PM
Krenair renamed this task from dbtree loads third party resources (from jquery.com) to dbtree loads third party resources (from jquery.com and google.com).Aug 21 2015, 11:09 AM

It's not just jQuery, but also the Google Visualisation API

Change 239568 had a related patch set uploaded (by Reedy):
Bundle jquery 1.9.1

https://gerrit.wikimedia.org/r/239568

It's not just jQuery, but also the Google Visualisation API

Fixing that one isn't going to be so easy

https://www.google.com/jsapi
https://www.google.com/jsapi?autoload={"modules":[{"name":"visualization","version":"1","packages":["corechart","table","orgchart"]}]}

Then reference many other files hosted on Google etc

Dzahn moved this task from Backlog to Services to fix on the HTTPS board.

This will probably be obsoleted by T119619, so I would mark this as stalled and blocked by a decision there.

Change 239568 abandoned by Reedy:
Bundle jquery 1.11.3

https://gerrit.wikimedia.org/r/239568

Grafana should substitute the graphing library

. The only thing left is substituting code to generate a tree (d3 library?). Any volunteers?

Aklapper added a subscriber: Springle.

[ Resetting assignee as assignee account is not active anymore ]

Krinkle renamed this task from dbtree loads third party resources (from jquery.com and google.com) to dbtree loads third party resources (from google.com/jsapi).Mar 10 2020, 1:31 AM
Krinkle updated the task description. (Show Details)
LSobanski lowered the priority of this task from Medium to Lowest.Apr 26 2021, 10:07 AM