Page MenuHomePhabricator

dbtree loads third party resources (from jquery.com and google.com)
Open, Stalled, NormalPublic

Description

https://dbtree.wikimedia.org/ now loads stuff from jquery.com and shows only a white page if that domain is not loaded by the browser. Please load jquery from a Wikimedia domain.

If you want to load third party resources, per the privacy policy you need a disclaimer somewhere in the page.

Code is in operations/software/dbtree

Event Timeline

Nemo_bis created this task.Apr 19 2015, 8:28 AM
Nemo_bis raised the priority of this task from to Normal.
Nemo_bis updated the task description. (Show Details)
Nemo_bis added a subscriber: Nemo_bis.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 19 2015, 8:28 AM
Nemo_bis updated the task description. (Show Details)Apr 19 2015, 8:55 AM
Nemo_bis set Security to None.
Krenair added a subscriber: Krenair.
Dzahn added a subscriber: Dzahn.Apr 25 2015, 12:07 AM

Do we already have jquery sitting on a wikimedia URL?

Krinkle added a comment.EditedApr 30 2015, 11:49 PM

No, please don't use bits.wikimedia.org outside a MediaWiki context. It hardcodes details outside of the separation of concerns. It also moves the version requirement to an unrelated software package.

Just add a distribution file to the repo that provides this dashboard. E.g. from {docroot}/lib/jquery/jquery-1.9.1.js or something like that.

Aklapper renamed this task from dbtree loads third party resources to dbtree loads third party resources (from jquery.com).May 19 2015, 12:56 PM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptAug 21 2015, 11:06 AM
Krenair renamed this task from dbtree loads third party resources (from jquery.com) to dbtree loads third party resources (from jquery.com and google.com).Aug 21 2015, 11:09 AM

It's not just jQuery, but also the Google Visualisation API

Change 239568 had a related patch set uploaded (by Reedy):
Bundle jquery 1.9.1

https://gerrit.wikimedia.org/r/239568

Reedy added a subscriber: Reedy.Sep 19 2015, 4:57 PM

It's not just jQuery, but also the Google Visualisation API

Fixing that one isn't going to be so easy

https://www.google.com/jsapi
https://www.google.com/jsapi?autoload={"modules":[{"name":"visualization","version":"1","packages":["corechart","table","orgchart"]}]}

Then reference many other files hosted on Google etc

Krinkle moved this task from Triage to Backlog on the DBA board.Sep 23 2015, 4:27 AM
Krinkle moved this task from Backlog to Triage on the DBA board.Sep 23 2015, 7:03 AM
Dzahn moved this task from Backlog to Services to fix on the HTTPS board.

This will probably be obsoleted by T119619, so I would mark this as stalled and blocked by a decision there.

Restricted Application added a subscriber: JEumerus. · View Herald TranscriptFeb 23 2016, 6:12 PM
ZhouZ moved this task from Backlog to Assigned on the WMF-Legal board.Apr 14 2016, 1:13 AM
ZhouZ added a subscriber: ZhouZ.

Change 239568 abandoned by Reedy:
Bundle jquery 1.11.3

https://gerrit.wikimedia.org/r/239568

Change 239568 restored by Dzahn:
Bundle jquery 1.11.3

https://gerrit.wikimedia.org/r/239568

Change 239568 merged by Dzahn:
Bundle jquery 1.11.3

https://gerrit.wikimedia.org/r/239568

Grafana should substitute the graphing library

. The only thing left is substituting code to generate a tree (d3 library?). Any volunteers?

ZhouZ moved this task from Assigned to Legal Done on the WMF-Legal board.Sep 1 2016, 9:07 PM
BBlack moved this task from Triage to Watching on the Traffic board.Oct 4 2016, 12:46 PM
BBlack moved this task from Watching to BadHerald on the Traffic board.Oct 4 2016, 1:27 PM
Aklapper removed Springle as the assignee of this task.Jul 10 2017, 8:09 AM
Aklapper added a subscriber: Springle.

[ Resetting assignee as assignee account is not active anymore ]

Marostegui moved this task from Triage to Backlog (help welcome) on the DBA board.Dec 4 2018, 8:04 AM