Page MenuHomePhabricator
Create Task
Maniphest T96527

A13. <*-thanked> in French requires the gender of the thanked user
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Reported by Vatadoshu at Wikipédia:Flow/Bugs.

The two messages <thanks-thanked> and <thanks-button-thanked> are only given the name of the current user, but the French translation (“remercié” or “remerciée”) depends on the gender of the thanked user.

This is done from javascript, so likely the api calls need to return information about the gender of the user, or make a second api call (https://www.mediawiki.org/wiki/API:Users). Can probably do the two api calls in parallel

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Flowmaster+7 -13Use PostCollection in thankAction to get the author gender
mediawiki/extensions/Flowmaster+23 -9Adjust the flow-thank* messages to use recipient gender
mediawiki/extensions/Thanksmaster+7 -7Further document Thanks gender (both en and qqq), and fix bug
mediawiki/extensions/Thanksmaster+99 -38Check the thanked user's gender for Thanks messages
Customize query in gerrit

Related Objects

Event Timeline

Ltrlg created this task.Apr 19 2015, 8:56 PM
Ltrlg raised the priority of this task from to Needs Triage.
Ltrlg updated the task description. (Show Details)
Ltrlg added projects: I18n, Thanks.
Ltrlg added a subscriber: Ltrlg.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 19 2015, 8:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
EBernhardson triaged this task as Medium priority.Apr 20 2015, 5:49 PM
EBernhardson added a subscriber: EBernhardson.

This is done from javascript, so likely the api calls need to return information about the gender of the user, or make a second api call. Can probably do the two api calls in parallel

• Mattflaschen-WMF updated the task description. (Show Details)Apr 22 2015, 6:39 PM
• Mattflaschen-WMF set Security to None.
• Mattflaschen-WMF updated the task description. (Show Details)
DannyH edited a custom field.Apr 22 2015, 6:47 PM
DannyH moved this task from Ready for next sprint to Current workboard on the Collaboration-Team-Triage board.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 22 2015, 7:08 PM
DannyH renamed this task from <*-thanked> in French requires the gender of the thanked user to A13. <*-thanked> in French requires the gender of the thanked user.Apr 22 2015, 8:05 PM
DannyH moved this task from Current workboard to Untriaged on the Collaboration-Team-Triage board.
gerritbot added a subscriber: gerritbot.Apr 22 2015, 11:24 PM

Change 206013 had a related patch set uploaded (by Mooeypoo):
Check the thanked user gender for Thanks messages

https://gerrit.wikimedia.org/r/206013

Mooeypoo claimed this task.Apr 22 2015, 11:26 PM
Mooeypoo added a subscriber: • MSchottlender-WMF.
Elitre added a subscriber: Elitre.May 4 2015, 2:36 PM
gerritbot added a comment.May 5 2015, 12:50 AM

Change 206013 merged by jenkins-bot:
Check the thanked user's gender for Thanks messages

https://gerrit.wikimedia.org/r/206013

gerritbot added a comment.May 5 2015, 4:36 AM

Change 208900 had a related patch set uploaded (by Mattflaschen):
Further document Thanks gender (both en and qqq), and fix bug

https://gerrit.wikimedia.org/r/208900

• Mattflaschen-WMF added a comment.May 5 2015, 4:40 AM

@Mooeypoo, I missed the above (208900) in code review, so I decided to fix that part myself.

Note there's a bug, not just the documentation, so the fix needs to make the branch cut. Also, this should ensure the messages are all marked as outdated so translators know they can update them should they choose.

Also, flow-thank-link (and probably flow-thank-link-title) also needs to be updated.

gerritbot added a comment.May 5 2015, 7:02 PM

Change 208900 merged by jenkins-bot:
Further document Thanks gender (both en and qqq), and fix bug

https://gerrit.wikimedia.org/r/208900

gerritbot added a comment.May 7 2015, 8:41 PM

Change 209624 had a related patch set uploaded (by Mooeypoo):
Adjust the flow-thank* messages to use recipient gender

https://gerrit.wikimedia.org/r/209624

gerritbot added a comment.May 8 2015, 8:47 PM

Change 209624 merged by jenkins-bot:
Adjust the flow-thank* messages to use recipient gender

https://gerrit.wikimedia.org/r/209624

• Mattflaschen-WMF added a comment.May 8 2015, 8:52 PM

There's one case where this doesn't work (posts that start a topic). I'll take care of fixing it to handle that.

gerritbot added a comment.May 14 2015, 12:35 AM

Change 210839 had a related patch set uploaded (by Mooeypoo):
Use PostCollection in thankAction to get the author gender

https://gerrit.wikimedia.org/r/210839

gerritbot added a comment.May 14 2015, 6:12 PM

Change 210839 merged by jenkins-bot:
Use PostCollection in thankAction to get the author gender

https://gerrit.wikimedia.org/r/210839

Etonkovidova added a subscriber: Etonkovidova.May 19 2015, 9:35 AM

There is another bug: T99662 Changing User preferences does not get reflected in "Thanked"(French)

DannyH closed this task as Resolved.May 19 2015, 8:20 PM
DannyH added a subscriber: DannyH.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL