Reported by Vatadoshu at Wikipédia:Flow/Bugs.
The two messages <thanks-thanked> and <thanks-button-thanked> are only given the name of the current user, but the French translation (“remercié” or “remerciée”) depends on the gender of the thanked user.
This is done from javascript, so likely the api calls need to return information about the gender of the user, or make a second api call (https://www.mediawiki.org/wiki/API:Users). Can probably do the two api calls in parallel
This is done from javascript, so likely the api calls need to return information about the gender of the user, or make a second api call. Can probably do the two api calls in parallel
Change 206013 had a related patch set uploaded (by Mooeypoo):
Check the thanked user gender for Thanks messages
Change 206013 merged by jenkins-bot:
Check the thanked user's gender for Thanks messages
Change 208900 had a related patch set uploaded (by Mattflaschen):
Further document Thanks gender (both en and qqq), and fix bug
@Mooeypoo, I missed the above (208900) in code review, so I decided to fix that part myself.
Note there's a bug, not just the documentation, so the fix needs to make the branch cut. Also, this should ensure the messages are all marked as outdated so translators know they can update them should they choose.
Also, flow-thank-link (and probably flow-thank-link-title) also needs to be updated.
Change 208900 merged by jenkins-bot:
Further document Thanks gender (both en and qqq), and fix bug
Change 209624 had a related patch set uploaded (by Mooeypoo):
Adjust the flow-thank* messages to use recipient gender
Change 209624 merged by jenkins-bot:
Adjust the flow-thank* messages to use recipient gender
There's one case where this doesn't work (posts that start a topic). I'll take care of fixing it to handle that.
Change 210839 had a related patch set uploaded (by Mooeypoo):
Use PostCollection in thankAction to get the author gender
Change 210839 merged by jenkins-bot:
Use PostCollection in thankAction to get the author gender
There is another bug: T99662 Changing User preferences does not get reflected in "Thanked"(French)