Empty annotations cannot be deleted
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Catrope
	Apr 19 2015, 9:02 PM

Description

Empty annotations like  are converted to meta items. So if you have a bunch of paragraphs like Foobar and delete them all, you end up with a pile of ... tags. This is especially bad when this happens in table cells whose row is deleted, because then the  stuff ends up being foster-parented out of the table.

Details

Subject	Repo	Branch	Lines +/-
Update VE core submodule to master (d9ece414a)	mediawiki/extensions/VisualEditor	master	+3 -1
ve.dm.MetaItem: Add removable flag	VisualEditor/VisualEditor	master	+142 -43
ve.dm.MetaItem: Add removable flag, split from internal state	VisualEditor/VisualEditor	master	+108 -30

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• ppelberg	T197990 Visual editor inserts extraneous blank lines (due to <nowiki/> pulled out of paragraph and then disappearing)
		Resolved		• ppelberg	T96528 Empty annotations cannot be deleted

Event Timeline

Catrope created this task.Apr 19 2015, 9:02 PM

Catrope assigned this task to Esanders.

Catrope raised the priority of this task from to Needs Triage.

Catrope updated the task description. (Show Details)

Catrope subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 19 2015, 9:02 PM

Catrope added projects: VisualEditor, VisualEditor-DataModel.Apr 19 2015, 9:02 PM

Catrope set Security to None.

What are the real world examples where these annotations come up?

Could we flag some meta items as 'deletable' for the transaction builder?

In T96528#1220432, @Esanders wrote:

What are the real world examples where these annotations come up?

https://office.wikimedia.org/w/index.php?diff=prev&oldid=144735 was where we noticed it.

Jdforrester-WMF triaged this task as Medium priority.Apr 20 2015, 2:22 PM

Jdforrester-WMF added a project: VisualEditor 2014/15 Q4 blockers.

Change 205291 had a related patch set uploaded (by Esanders):
Add removable flag to meta items

https://gerrit.wikimedia.org/r/205291

gerritbot added a project: Patch-For-Review.Apr 20 2015, 4:42 PM

Jdforrester-WMF moved this task from Nominated to Backlog on the VisualEditor 2014/15 Q4 blockers board.Apr 29 2015, 6:27 PM

Jdforrester-WMF edited a custom field.Apr 29 2015, 7:28 PM

Jdforrester-WMF moved this task from Backlog to Doing on the VisualEditor 2014/15 Q4 blockers board.May 6 2015, 10:16 PM

Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.May 8 2015, 1:41 AM

Jdforrester-WMF moved this task from Blocked to TR0: Interrupt on the VisualEditor board.Jun 18 2015, 1:30 AM

Jdforrester-WMF added a project: VisualEditor 2015/16 Q1 blockers.Jul 1 2015, 3:52 PM

Jdforrester-WMF moved this task from Nominated to Doing on the VisualEditor 2015/16 Q1 blockers board.

Jdforrester-WMF removed a project: VisualEditor 2014/15 Q4 blockers.Jul 1 2015, 3:54 PM

Jdforrester-WMF removed a project: VisualEditor 2015/16 Q1 blockers.Jul 21 2015, 6:29 PM

De-prioritising, now that Parsoid trims empty annotations (at least some of the time).

Jdforrester-WMF moved this task from TR0: Interrupt to Freezer on the VisualEditor board.Jul 22 2015, 11:49 PM

• Deskana removed Esanders as the assignee of this task.Oct 16 2017, 1:04 PM

• Deskana added a subscriber: Esanders.

Change 205291 abandoned by Esanders:
ve.dm.MetaItem: Add removable flag, split from internal state

Reason:
Metadata no longer exists, bug has been fixed in Parsoid.

https://gerrit.wikimedia.org/r/205291

Testing this on Beta Cluster just now given the prompt of the old code being abandonned, I confirmed that this is a problem (and possibly it's worse than it was before?):

https://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:Jdforrester_(WMF)/T96528&diff=377705&oldid=377704&diffmode=source

matmarex mentioned this in T197990: Visual editor inserts extraneous blank lines (due to <nowiki/> pulled out of paragraph and then disappearing).Jun 27 2018, 3:30 PM

matmarex added a subtask: T197990: Visual editor inserts extraneous blank lines (due to <nowiki/> pulled out of paragraph and then disappearing).

Change 442335 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] ve.dm.MetaItem: Add removable flag

https://gerrit.wikimedia.org/r/442335

gerritbot added a project: Patch-For-Review.Jun 27 2018, 4:14 PM

matmarex removed a subtask: T197990: Visual editor inserts extraneous blank lines (due to <nowiki/> pulled out of paragraph and then disappearing).May 9 2019, 7:42 PM

matmarex added a parent task: T197990: Visual editor inserts extraneous blank lines (due to <nowiki/> pulled out of paragraph and then disappearing).

matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.May 9 2019, 7:44 PM

matmarex moved this task from Incoming to Code review on the VisualEditor (Current work) board.

Change 442335 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.dm.MetaItem: Add removable flag

https://gerrit.wikimedia.org/r/442335

Change 513192 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d9ece414a)

https://gerrit.wikimedia.org/r/513192

Change 513192 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d9ece414a)

https://gerrit.wikimedia.org/r/513192

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.8; 2019-06-04).May 29 2019, 10:00 PM

matmarex moved this task from Code review to Engineering QA on the VisualEditor (Current work) board.May 29 2019, 10:13 PM

matmarex moved this task from Engineering QA to Product owner review on the VisualEditor (Current work) board.Jul 11 2019, 10:34 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 11 2019, 11:11 PM

• ppelberg closed this task as Resolved.Aug 6 2019, 2:50 AM

• ppelberg claimed this task.

matmarex mentioned this in T264027: <nowiki/> tag removed inside template parameter.Aug 23 2021, 1:57 PM