Page MenuHomePhabricator
Create Task
Maniphest T96573

Prevent from selecting the same source and target languages in new translation dialog
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

It should not be possible to select the same language as source and target. Currently you can change the source to the same language the target is:

At the ongoing translations you can see a Bulgatian-to-Bulgarian translation probably started because of this bug.

The way it used to work (and how it should) is:

  • If you have (Source: X, Target: Y), and Target is changed to X the result is (Source: Y, Target: X).
  • If you have (Source: X, Target: Y), and Source is changed to Y the result is (Source: Y, Target: X).

That is, trying to select the same language becamoes a shortcut to switch source and target languages.

Given that this was working previously, it may be a good idea to write some tests that prevent future regressions.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/ContentTranslationmaster+13 -3Prevent swapping to an invalid target language
mediawiki/extensions/ContentTranslationmaster+19 -7Don't let source and target languages be the same
Customize query in gerrit

Related Objects

Event Timeline

Pginer-WMF created this task.Apr 20 2015, 4:41 PM
Pginer-WMF raised the priority of this task from to Needs Triage.
Pginer-WMF updated the task description. (Show Details)
Pginer-WMF added projects: ContentTranslation, LE-Sprint-85, LE-Sprint-86, ContentTranslation-Release3.
Pginer-WMF added a subscriber: Pginer-WMF.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2015, 4:41 PM
Arrbee edited projects, added ContentTranslation-Release5; removed ContentTranslation-Release3, LE-Sprint-85.Apr 20 2015, 5:15 PM
Arrbee set Security to None.
Liuxinyu970226 added a subscriber: Liuxinyu970226.Apr 21 2015, 7:11 AM
Arrbee triaged this task as Low priority.Apr 21 2015, 8:54 AM
Arrbee edited a custom field.
Amire80 claimed this task.Apr 21 2015, 9:49 AM
Amire80 added a subscriber: Amire80.

Closely related to T94869, i'll do them together.

Pginer-WMF added a comment.Apr 21 2015, 4:46 PM

Thanks @Amire80!

Liuxinyu970226 removed a subscriber: Liuxinyu970226.Apr 22 2015, 10:44 AM
Arrbee moved this task from Backlog to In Progress on the LE-Sprint-86 board.May 6 2015, 7:25 AM
Amire80 moved this task from In Progress to In Review on the LE-Sprint-86 board.May 6 2015, 7:51 PM
gerritbot added a subscriber: gerritbot.May 6 2015, 7:52 PM

Change 209315 had a related patch set uploaded (by Amire80):
Don't let source and target languages be the same

https://gerrit.wikimedia.org/r/209315

gerritbot added a project: Patch-For-Review.May 6 2015, 7:52 PM
gerritbot added a comment.May 18 2015, 9:06 AM

Change 209315 merged by jenkins-bot:
Don't let source and target languages be the same

https://gerrit.wikimedia.org/r/209315

Nikerabbit mentioned this in rECTXd0c8f3778452: Don't let source and target languages be the same.May 18 2015, 9:06 AM
Amire80 mentioned this in rMEXT0dd097946918: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….May 18 2015, 9:06 AM
Amire80 reassigned this task from Amire80 to Pginer-WMF.May 18 2015, 9:28 AM
Amire80 removed a project: Patch-For-Review.

@Pginer-WMF, can you please test that it's good now?

Pginer-WMF added a comment.May 19 2015, 9:54 AM

@Pginer-WMF, can you please test that it's good now?

It works well in general but there is a problem with languages that are only partially supported (e.g., supported as source but not as target).
For example if the default choice is "English -> Spanish", and I switch the source language to be Spanish, the result shown is "Spanish -> English" which we don't support since English is not yet available as a target language. In that context, we can either (a) show English as disabled when it appears as a target language, or (b) just replace English with another valid target language (Simple English could be a good default).

In the long term, when all languages can be used as source and target, this should not be an issue.

Arrbee added a subscriber: Arrbee.May 25 2015, 8:06 AM

Timeboxed to EOD 26th May 2015

Arrbee reassigned this task from Pginer-WMF to Amire80.May 25 2015, 8:06 AM
santhosh moved this task from Backlog to Bugs on the ContentTranslation-Release5 board.May 25 2015, 8:50 AM
gerritbot added a comment.May 27 2015, 9:36 AM

Change 214019 had a related patch set uploaded (by Amire80):
Prevent swapping to an invalid target language

https://gerrit.wikimedia.org/r/214019

gerritbot added a project: Patch-For-Review.May 27 2015, 9:36 AM
gerritbot added a comment.Jun 8 2015, 9:36 AM

Change 214019 merged by jenkins-bot:
Prevent swapping to an invalid target language

https://gerrit.wikimedia.org/r/214019

Diffusion mentioned this in rMEXT9aa1342e9053: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Jun 8 2015, 9:36 AM
Amire80 mentioned this in rECTX6d761286ccc3: Prevent swapping to an invalid target language.Jun 8 2015, 9:36 AM
Amire80 removed a project: Patch-For-Review.Jun 8 2015, 9:56 AM

Can this be closed?

Forrestbot added a project: WMF-deploy-2015-06-09_(1.26wmf9).Jun 8 2015, 6:02 PM
Forrestbot added a subscriber: Forrestbot.
Arrbee closed this task as Resolved.Jun 9 2015, 8:09 AM
Arrbee moved this task from In Review to Done on the LE-Sprint-86 board.
Legoktm removed a subscriber: Forrestbot.Jun 29 2015, 5:49 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL